Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH][gdb/testsuite] Fix gdb.reverse/insn-reverse-x86.c for -m32
Date: Wed, 25 Nov 2020 12:17:06 +0100	[thread overview]
Message-ID: <20201125111705.GA1176@delia.home> (raw)

Hi,

When running test-case gdb.reverse/insn-reverse.exp with target board
unix/-m32, we get:
...
spawn -ignore SIGHUP gcc -fno-stack-protector -fdiagnostics-color=never \
  -c -g -m32 -o insn-reverse0.o insn-reverse.c^M
insn-reverse-x86.c: Assembler messages:^M
insn-reverse-x86.c:88: Error: bad register name `%r8w'^M
....

Fix this by guarding x86_64 assembly in insn-reverse-x86.c with #ifdef
__x86_64__.

Tested on x86_64-linux, with native and unix/-m32.

Any comments?

Thanks,
- Tom

[gdb/testsuite] Fix gdb.reverse/insn-reverse-x86.c for -m32

gdb/testsuite/ChangeLog:

2020-11-25  Tom de Vries  <tdevries@suse.de>

	* gdb.reverse/insn-reverse-x86.c: Guard x86_64 assembly with #ifdef
	__x86_64__.

---
 gdb/testsuite/gdb.reverse/insn-reverse-x86.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gdb/testsuite/gdb.reverse/insn-reverse-x86.c b/gdb/testsuite/gdb.reverse/insn-reverse-x86.c
index 22ba97a50d7..4392cb66def 100644
--- a/gdb/testsuite/gdb.reverse/insn-reverse-x86.c
+++ b/gdb/testsuite/gdb.reverse/insn-reverse-x86.c
@@ -85,6 +85,7 @@ rdrand (void)
   __asm__ volatile ("rdrand %%sp;" : "=r" (number));
   __asm__ volatile ("mov %%ax, %%sp;" : "=r" (number));
 
+#ifdef __x86_64__
   __asm__ volatile ("rdrand %%r8w;" : "=r" (number));
   __asm__ volatile ("rdrand %%r9w;" : "=r" (number));
   __asm__ volatile ("rdrand %%r10w;" : "=r" (number));
@@ -93,6 +94,7 @@ rdrand (void)
   __asm__ volatile ("rdrand %%r13w;" : "=r" (number));
   __asm__ volatile ("rdrand %%r14w;" : "=r" (number));
   __asm__ volatile ("rdrand %%r15w;" : "=r" (number));
+#endif
 
   /* 32-bit random numbers.  */
   __asm__ volatile ("rdrand %%eax;" : "=r" (number));
@@ -100,6 +102,7 @@ rdrand (void)
   __asm__ volatile ("rdrand %%ecx;" : "=r" (number));
   __asm__ volatile ("rdrand %%edx;" : "=r" (number));
 
+#ifdef __x86_64__
   __asm__ volatile ("mov %%rdi, %%rax;" : "=r" (number));
   __asm__ volatile ("rdrand %%edi;" : "=r" (number));
   __asm__ volatile ("mov %%rax, %%rdi;" : "=r" (number));
@@ -155,6 +158,7 @@ rdrand (void)
   __asm__ volatile ("rdrand %%r13;" : "=r" (number));
   __asm__ volatile ("rdrand %%r14;" : "=r" (number));
   __asm__ volatile ("rdrand %%r15;" : "=r" (number));
+#endif
 }
 
 /* Test rdseed support for various output registers.  */
@@ -190,6 +194,7 @@ rdseed (void)
   __asm__ volatile ("rdseed %%sp;" : "=r" (seed));
   __asm__ volatile ("mov %%ax, %%sp;" : "=r" (seed));
 
+#ifdef __x86_64__
   __asm__ volatile ("rdseed %%r8w;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r9w;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r10w;" : "=r" (seed));
@@ -198,6 +203,7 @@ rdseed (void)
   __asm__ volatile ("rdseed %%r13w;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r14w;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r15w;" : "=r" (seed));
+#endif
 
   /* 32-bit random seeds.  */
   __asm__ volatile ("rdseed %%eax;" : "=r" (seed));
@@ -205,6 +211,7 @@ rdseed (void)
   __asm__ volatile ("rdseed %%ecx;" : "=r" (seed));
   __asm__ volatile ("rdseed %%edx;" : "=r" (seed));
 
+#ifdef __x86_64__
   __asm__ volatile ("mov %%rdi, %%rax;" : "=r" (seed));
   __asm__ volatile ("rdseed %%edi;" : "=r" (seed));
   __asm__ volatile ("mov %%rax, %%rdi;" : "=r" (seed));
@@ -260,6 +267,7 @@ rdseed (void)
   __asm__ volatile ("rdseed %%r13;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r14;" : "=r" (seed));
   __asm__ volatile ("rdseed %%r15;" : "=r" (seed));
+#endif
 }
 
 /* Initialize arch-specific bits.  */

                 reply	other threads:[~2020-11-25 11:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125111705.GA1176@delia.home \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox