From: Ulrich Weigand via Gdb-patches <gdb-patches@sourceware.org>
To: Rogerio Alves <rcardoso@linux.ibm.com>
Cc: pedromfc@linux.ibm.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v1] [powerpc] Remove 512 bytes region limit if using 2nd DAWR.
Date: Mon, 9 Nov 2020 11:24:34 +0100 [thread overview]
Message-ID: <20201109102434.GA12858@oc3748833570.ibm.com> (raw)
In-Reply-To: <20201109021204.48664-1-rcardoso@linux.ibm.com>
On Sun, Nov 08, 2020 at 11:12:04PM -0300, Rogerio Alves wrote:
> Power 10 introduces the 2nd DAWR (second watchpoint) and also removed
> a restriction that limit the watch region to 512 bytes.
>
> 2020-11-08 Rogerio A. Cardoso <rcardoso@linux.ibm.com>
>
> gdb/
>
> * ppc-linux-nat.c: (PPC_DEBUG_FEATURE_DATA_BP_ARCH_31): New define.
> (region_ok_for_hw_watchpoint): Check if 2nd DAWR is avaliable before set
> region.
This doesn't look correct, the patch not only removes the alignment
requirement but actually removes support for 512 bytes ranges itself!
I think for P10 we need to continue to allow watched ranges up to
512 bytes in size, but they only need to be 8 byte aligned now and
may cross a 512-byte boundary.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2020-11-09 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 2:12 Rogerio Alves via Gdb-patches
2020-11-09 10:24 ` Ulrich Weigand via Gdb-patches [this message]
2020-11-09 13:08 ` Rogerio Alves via Gdb-patches
2020-11-10 10:21 ` Ulrich Weigand via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109102434.GA12858@oc3748833570.ibm.com \
--to=gdb-patches@sourceware.org \
--cc=pedromfc@linux.ibm.com \
--cc=rcardoso@linux.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox