From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U8bjGO0YqV8cZgAAWB0awg (envelope-from ) for ; Mon, 09 Nov 2020 05:24:45 -0500 Received: by simark.ca (Postfix, from userid 112) id 584971F08B; Mon, 9 Nov 2020 05:24:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E79F11E552 for ; Mon, 9 Nov 2020 05:24:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C7AE384A022; Mon, 9 Nov 2020 10:24:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C7AE384A022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1604917483; bh=WiIUzm99KxdwZxcoL7Ybmxv1ENTRnUbu9ve2d8v2gRU=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jF+89VGwn2q4lTSAWl6HAQKBqGk7jY8M+JwlubXG+Q1duNNwI15oYHQj/axdERACh t2BFpqGYCdyo74r9v+S2xWHngtk5sRn0bM+S13tKQ9hjCXnUo81iufXFF/VROtol3m ae9Pn8WRAeofT39J31RDMdSUkyW8TBKWEshOp6zA= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B7502386103A for ; Mon, 9 Nov 2020 10:24:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B7502386103A Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A9A2PZE010194 for ; Mon, 9 Nov 2020 05:24:40 -0500 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 34nrhqpyer-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Nov 2020 05:24:39 -0500 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A9AHjbj012694 for ; Mon, 9 Nov 2020 10:24:37 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma05fra.de.ibm.com with ESMTP id 34nk788ytf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Nov 2020 10:24:37 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A9AOYGC38076908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Nov 2020 10:24:34 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A0CFCA4055; Mon, 9 Nov 2020 10:24:34 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 982AEA4051; Mon, 9 Nov 2020 10:24:34 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.145.165.52]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 9 Nov 2020 10:24:34 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 0C219D803D6; Mon, 9 Nov 2020 11:24:34 +0100 (CET) Date: Mon, 9 Nov 2020 11:24:34 +0100 To: Rogerio Alves Subject: Re: [PATCH v1] [powerpc] Remove 512 bytes region limit if using 2nd DAWR. Message-ID: <20201109102434.GA12858@oc3748833570.ibm.com> References: <20201109021204.48664-1-rcardoso@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109021204.48664-1-rcardoso@linux.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-09_02:2020-11-05, 2020-11-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=866 priorityscore=1501 bulkscore=0 clxscore=1011 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011090061 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Ulrich Weigand via Gdb-patches Reply-To: Ulrich Weigand Cc: pedromfc@linux.ibm.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sun, Nov 08, 2020 at 11:12:04PM -0300, Rogerio Alves wrote: > Power 10 introduces the 2nd DAWR (second watchpoint) and also removed > a restriction that limit the watch region to 512 bytes. > > 2020-11-08 Rogerio A. Cardoso > > gdb/ > > * ppc-linux-nat.c: (PPC_DEBUG_FEATURE_DATA_BP_ARCH_31): New define. > (region_ok_for_hw_watchpoint): Check if 2nd DAWR is avaliable before set > region. This doesn't look correct, the patch not only removes the alignment requirement but actually removes support for 512 bytes ranges itself! I think for P10 we need to continue to allow watched ranges up to 512 bytes in size, but they only need to be 8 byte aligned now and may cross a 512-byte boundary. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com