From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix debug expression dumping of function call expressions
Date: Fri, 6 Nov 2020 20:59:11 +0000 [thread overview]
Message-ID: <20201106205911.GJ2729@embecosm.com> (raw)
In-Reply-To: <87h7q2ib4c.fsf@tromey.com>
* Tom Tromey <tom@tromey.com> [2020-11-06 11:38:43 -0700]:
> Andrew> In this commit I have cleaned up all of the debug-expr.exp files a
> Andrew> little, there was a helper function that had clearly been copied into
> Andrew> each file, this is now moved into lib/gdb.exp.
>
> Andrew> I've added a gdb.fortran/debug-expr.exp test file, and extended
> Andrew> gdb.base/debug-expr.exp to cover the function call case.
>
> This looks good to me. Thank you for doing this.
Thanks, pushed.
Andrew
prev parent reply other threads:[~2020-11-06 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 18:18 Andrew Burgess
2020-11-06 18:38 ` Tom Tromey
2020-11-06 20:59 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106205911.GJ2729@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox