From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U0vzAya5pV9JHAAAWB0awg (envelope-from ) for ; Fri, 06 Nov 2020 15:59:18 -0500 Received: by simark.ca (Postfix, from userid 112) id 034461F08B; Fri, 6 Nov 2020 15:59:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4658F1E58D for ; Fri, 6 Nov 2020 15:59:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FB6F3844047; Fri, 6 Nov 2020 20:59:16 +0000 (GMT) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 466CA3857027 for ; Fri, 6 Nov 2020 20:59:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 466CA3857027 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x32f.google.com with SMTP id h2so2748258wmm.0 for ; Fri, 06 Nov 2020 12:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2zYu5phxLKP+vQdvJoMd4QQsNkIkSFhOk5/5ARPw1V8=; b=JyEx8T3iha/DJG9aStE6dpWS/Sh6h97+KtW3K0lC5HMVmsegathZ2jqhB0DwiMOs5y ZY3iy3u0qcqFfcLvl3KqL9IEnPukLKR/4KUViayzpGxzTjwQQoSUTUf1HpcVCcKHI1+h Ojgvb0cpixXKv79Odcwm+nZEd9UjWbe1dTMmlDGsrWmlA1XYkZ5TqbY4lnkBc5pjJgtw 7VH4P/ezlUEbh0EY2Ea4MAkDgEW6bm4qGtCSUgcnb249tmjnW7puX5w2oWHr9DReOMUF RBrB2+NR5EYghZtj4/k7m5HFWkKl8W/9CBNHsvt2jcR/1l3NyWu7NRj00hJfyHklD7KY ecYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2zYu5phxLKP+vQdvJoMd4QQsNkIkSFhOk5/5ARPw1V8=; b=RvrlEj5IQzLRN6wi7j19j2t12lYKbOLyu0+qBcsCXP5/lZYdnwAF5JJyiFdG5kb6AX Meux+BiFi4lK8RLf6s/o0Wd5V5iVwqleBqw5jEjEMX6SABylY6Op6Nje3FsF6ktpueIX QA//Qpjz8bts11cY1Q8zfG35/ZcKJzexhFygNtR7LXPYv78qkhtzeVt0dZ50fZ/MTXJP Qms4GGB6k2rlmd0ijkSXwMLdGQtkuvxciP9YF85ugNYTWr7kkmXVUCK1LRcUfp5OTjeT RC65RiE5XMeFR6NQObNc9DmIpp7Gs+0GruUAEoZHhgpM/rSDI4vyeEdqs9PrjhZLjFi2 dc1A== X-Gm-Message-State: AOAM530AP4uQD0XNb258R0xKeikh71GfO/NNChvI79EzDWYdKN9RGrZa XZbgLBMGhzmkWqRlFLt8ahXjCrlqfr5JWw== X-Google-Smtp-Source: ABdhPJzP9hYO+oNugE9bcbQkwIx3O+VmqCdapzUGlQlLZiN5KSRj4x3E/IAbptf1q4MK/h+ZXuScEQ== X-Received: by 2002:a1c:230e:: with SMTP id j14mr1371157wmj.187.1604696353457; Fri, 06 Nov 2020 12:59:13 -0800 (PST) Received: from localhost (host109-154-72-197.range109-154.btcentralplus.com. [109.154.72.197]) by smtp.gmail.com with ESMTPSA id r18sm4365446wrj.50.2020.11.06.12.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 12:59:12 -0800 (PST) Date: Fri, 6 Nov 2020 20:59:11 +0000 From: Andrew Burgess To: Tom Tromey Subject: Re: [PATCH] gdb: fix debug expression dumping of function call expressions Message-ID: <20201106205911.GJ2729@embecosm.com> References: <20201106181859.437662-1-andrew.burgess@embecosm.com> <87h7q2ib4c.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h7q2ib4c.fsf@tromey.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 20:58:59 up 12 days, 12:02, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Tom Tromey [2020-11-06 11:38:43 -0700]: > Andrew> In this commit I have cleaned up all of the debug-expr.exp files a > Andrew> little, there was a helper function that had clearly been copied into > Andrew> each file, this is now moved into lib/gdb.exp. > > Andrew> I've added a gdb.fortran/debug-expr.exp test file, and extended > Andrew> gdb.base/debug-expr.exp to cover the function call case. > > This looks good to me. Thank you for doing this. Thanks, pushed. Andrew