From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Fix re-read FAILs with -readnow
Date: Wed, 28 Oct 2020 21:08:12 +0100 [thread overview]
Message-ID: <20201028200810.GA27896@delia> (raw)
Hi,
When running the testsuite with target board readnow, we run into:
...
FAIL: gdb.ada/exec_changed.exp: start second
FAIL: gdb.ada/exec_changed.exp: start just first
FAIL: gdb.base/reread.exp: opts= "" "" : run to foo() second time
FAIL: gdb.base/reread.exp: opts= "" "" : second pass: run to foo() second time
FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : \
run to foo() second time
FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: \
run to foo() second time
...
These are FAILs due to PR26800.
Mark these as KFAILs.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix re-read FAILs with -readnow
gdb/testsuite/ChangeLog:
2020-10-28 Tom de Vries <tdevries@suse.de>
* gdb.ada/exec_changed.exp: Add KFAILs for -readnow.
* gdb.base/reread.exp: Same.
---
gdb/testsuite/gdb.ada/exec_changed.exp | 8 ++++++++
gdb/testsuite/gdb.base/reread.exp | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/gdb/testsuite/gdb.ada/exec_changed.exp b/gdb/testsuite/gdb.ada/exec_changed.exp
index d8ee7597fe..ba14c0e68f 100644
--- a/gdb/testsuite/gdb.ada/exec_changed.exp
+++ b/gdb/testsuite/gdb.ada/exec_changed.exp
@@ -51,6 +51,8 @@ gdb_reinitialize_dir $srcdir/$subdir
gdb_test "shell mv ${binfile} ${common_binfile}" ".*" ""
gdb_load ${common_binfile}
+set readnow_p [readnow ${common_binfile}]
+
# Start the program, we should land in the program main procedure
if { [gdb_start_cmd] < 0 } {
untested start
@@ -76,6 +78,9 @@ gdb_test "shell touch ${common_binfile}" ".*" ""
if { [gdb_start_cmd] < 0 } {
fail "start second"
} else {
+ if { $readnow_p } {
+ setup_kfail "gdb/26800" *-*-*
+ }
gdb_test "" \
"second \\(\\) at .*second.adb.*" \
"start second"
@@ -103,6 +108,9 @@ if { [gdb_start_cmd] < 0 } {
gdb_test_no_output "set \$check_gdb_running = 0" "check gdb running"
fail "start just first"
} else {
+ if { $readnow_p } {
+ setup_kfail "gdb/26800" *-*-*
+ }
gdb_test "" \
"first \\(\\) at .*first.adb.*" \
"start just first"
diff --git a/gdb/testsuite/gdb.base/reread.exp b/gdb/testsuite/gdb.base/reread.exp
index f824156cc3..52c4da79db 100644
--- a/gdb/testsuite/gdb.base/reread.exp
+++ b/gdb/testsuite/gdb.base/reread.exp
@@ -67,6 +67,8 @@ foreach_with_prefix opts {
gdb_rename_execfile ${binfile1} ${binfile}
gdb_load ${binfile}
+ set readnow_p [readnow ${binfile}]
+
# Set a breakpoint at foo
gdb_test "break foo" \
@@ -97,6 +99,9 @@ foreach_with_prefix opts {
unsupported $test
} else {
gdb_run_cmd
+ if { $readnow_p } {
+ setup_kfail "gdb/26800" *-*-*
+ }
gdb_test "" "Breakpoint.* foo .* at .*:9.*" $test
}
@@ -133,6 +138,9 @@ foreach_with_prefix opts {
gdb_rename_execfile ${binfile} ${binfile1}
gdb_rename_execfile ${binfile2} ${binfile}
gdb_run_cmd
+ if { $readnow_p } {
+ setup_kfail "gdb/26800" *-*-*
+ }
gdb_test "" "Breakpoint.* foo .* at .*:9.*" \
"second pass: run to foo() second time"
}
reply other threads:[~2020-10-28 20:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028200810.GA27896@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox