From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eIkuL7LPmV96bwAAWB0awg (envelope-from ) for ; Wed, 28 Oct 2020 16:08:18 -0400 Received: by simark.ca (Postfix, from userid 112) id BF0711EFC1; Wed, 28 Oct 2020 16:08:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B7E91E590 for ; Wed, 28 Oct 2020 16:08:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CFA4F3851C0E; Wed, 28 Oct 2020 20:08:17 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 3784B385EC58 for ; Wed, 28 Oct 2020 20:08:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3784B385EC58 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4DFEEADD2 for ; Wed, 28 Oct 2020 20:08:14 +0000 (UTC) Date: Wed, 28 Oct 2020 21:08:12 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix re-read FAILs with -readnow Message-ID: <20201028200810.GA27896@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, When running the testsuite with target board readnow, we run into: ... FAIL: gdb.ada/exec_changed.exp: start second FAIL: gdb.ada/exec_changed.exp: start just first FAIL: gdb.base/reread.exp: opts= "" "" : run to foo() second time FAIL: gdb.base/reread.exp: opts= "" "" : second pass: run to foo() second time FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : \ run to foo() second time FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: \ run to foo() second time ... These are FAILs due to PR26800. Mark these as KFAILs. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix re-read FAILs with -readnow gdb/testsuite/ChangeLog: 2020-10-28 Tom de Vries * gdb.ada/exec_changed.exp: Add KFAILs for -readnow. * gdb.base/reread.exp: Same. --- gdb/testsuite/gdb.ada/exec_changed.exp | 8 ++++++++ gdb/testsuite/gdb.base/reread.exp | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/gdb/testsuite/gdb.ada/exec_changed.exp b/gdb/testsuite/gdb.ada/exec_changed.exp index d8ee7597fe..ba14c0e68f 100644 --- a/gdb/testsuite/gdb.ada/exec_changed.exp +++ b/gdb/testsuite/gdb.ada/exec_changed.exp @@ -51,6 +51,8 @@ gdb_reinitialize_dir $srcdir/$subdir gdb_test "shell mv ${binfile} ${common_binfile}" ".*" "" gdb_load ${common_binfile} +set readnow_p [readnow ${common_binfile}] + # Start the program, we should land in the program main procedure if { [gdb_start_cmd] < 0 } { untested start @@ -76,6 +78,9 @@ gdb_test "shell touch ${common_binfile}" ".*" "" if { [gdb_start_cmd] < 0 } { fail "start second" } else { + if { $readnow_p } { + setup_kfail "gdb/26800" *-*-* + } gdb_test "" \ "second \\(\\) at .*second.adb.*" \ "start second" @@ -103,6 +108,9 @@ if { [gdb_start_cmd] < 0 } { gdb_test_no_output "set \$check_gdb_running = 0" "check gdb running" fail "start just first" } else { + if { $readnow_p } { + setup_kfail "gdb/26800" *-*-* + } gdb_test "" \ "first \\(\\) at .*first.adb.*" \ "start just first" diff --git a/gdb/testsuite/gdb.base/reread.exp b/gdb/testsuite/gdb.base/reread.exp index f824156cc3..52c4da79db 100644 --- a/gdb/testsuite/gdb.base/reread.exp +++ b/gdb/testsuite/gdb.base/reread.exp @@ -67,6 +67,8 @@ foreach_with_prefix opts { gdb_rename_execfile ${binfile1} ${binfile} gdb_load ${binfile} + set readnow_p [readnow ${binfile}] + # Set a breakpoint at foo gdb_test "break foo" \ @@ -97,6 +99,9 @@ foreach_with_prefix opts { unsupported $test } else { gdb_run_cmd + if { $readnow_p } { + setup_kfail "gdb/26800" *-*-* + } gdb_test "" "Breakpoint.* foo .* at .*:9.*" $test } @@ -133,6 +138,9 @@ foreach_with_prefix opts { gdb_rename_execfile ${binfile} ${binfile1} gdb_rename_execfile ${binfile2} ${binfile} gdb_run_cmd + if { $readnow_p } { + setup_kfail "gdb/26800" *-*-* + } gdb_test "" "Breakpoint.* foo .* at .*:9.*" \ "second pass: run to foo() second time" }