Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang

[Gary Benson <gbenson@redhat.com>]

Pedro Alves wrote:
> On 8/17/20 2:24 PM, Gary Benson wrote:
> > Pedro Alves wrote:
> >> On 7/27/20 2:09 PM, Gary Benson via Gdb-patches wrote:
> >>> Furthermore, gdb.cp/ambiguous.exp has been disabled when using GCC
> >>> since 1998.
> >>
> >> Curious you reference the year, do you know it because you found the
> >> commit that disabled it?
> > 
> > Yes :)
> 
> What it was, then?  Does it say anything about why the testcase
> was disabled?

No, it was just "import YYYYMMDD snapshot" or some such thing.

> >>> -if { [test_compiler_info gcc-*] } then { continue }
> >>> +# GCCs prior to 10.1 do not support -Wno-inaccessible-base.
> >>> +if { [test_compiler_info {gcc-[0-9]-*}]
> >>> +     || [test_compiler_info {gcc-10-0-*}] } {
> >>
> >> Given the first release of GCC 10 is 10.1...
> > 
> > Ah, I didn't know that.
> > 
> >> ...do we really need the second check?
> > 
> > No :)  I've removed it.
> > 
> >>> +    unsupported "compiler does not support -Wno-inaccessible-base"
> >>
> >> How about instead of bailing out, use "-Wno-inaccessible-base"
> >> with GCC >= 10, and use "-w" with older GCCs?
> > 
> > Sure.  How about this?
> 
> OK.

Cool, thanks.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat