From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id D2A633857C47 for ; Mon, 17 Aug 2020 14:57:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2A633857C47 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-L23YOHSaPrm4q24fHK9EYg-1; Mon, 17 Aug 2020 10:57:33 -0400 X-MC-Unique: L23YOHSaPrm4q24fHK9EYg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E254681F001; Mon, 17 Aug 2020 14:57:32 +0000 (UTC) Received: from blade.nx (ovpn-114-47.ams2.redhat.com [10.36.114.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51F65D9D2; Mon, 17 Aug 2020 14:57:32 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id BA60B816CCA9; Mon, 17 Aug 2020 15:57:31 +0100 (BST) Date: Mon, 17 Aug 2020 15:57:31 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang Message-ID: <20200817145731.GA15727@blade.nx> References: <1597670664-14171-1-git-send-email-gbenson@redhat.com> <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> MIME-Version: 1.0 In-Reply-To: <4b7a4f2e-9e77-495a-759b-187aebb342aa@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 14:57:37 -0000 Pedro Alves wrote: > On 8/17/20 2:24 PM, Gary Benson wrote: > > Pedro Alves wrote: > >> On 7/27/20 2:09 PM, Gary Benson via Gdb-patches wrote: > >>> Furthermore, gdb.cp/ambiguous.exp has been disabled when using GCC > >>> since 1998. > >> > >> Curious you reference the year, do you know it because you found the > >> commit that disabled it? > > > > Yes :) > > What it was, then? Does it say anything about why the testcase > was disabled? No, it was just "import YYYYMMDD snapshot" or some such thing. > >>> -if { [test_compiler_info gcc-*] } then { continue } > >>> +# GCCs prior to 10.1 do not support -Wno-inaccessible-base. > >>> +if { [test_compiler_info {gcc-[0-9]-*}] > >>> + || [test_compiler_info {gcc-10-0-*}] } { > >> > >> Given the first release of GCC 10 is 10.1... > > > > Ah, I didn't know that. > > > >> ...do we really need the second check? > > > > No :) I've removed it. > > > >>> + unsupported "compiler does not support -Wno-inaccessible-base" > >> > >> How about instead of bailing out, use "-Wno-inaccessible-base" > >> with GCC >= 10, and use "-w" with older GCCs? > > > > Sure. How about this? > > OK. Cool, thanks. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat