Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Simon Marchi <simark@simark.ca>,
	Binutils <binutils@sourceware.org>,
	GDB <gdb-patches@sourceware.org>
Subject: Re: FYI: git-hooks update on sourceware.org
Date: Fri, 7 Aug 2020 09:44:36 -0700	[thread overview]
Message-ID: <20200807164436.GG3362@adacore.com> (raw)
In-Reply-To: <CAMe9rOrDukO_XqoPnieTsyvDUZS0EwwxxrmXn-kWu0mvNYCefQ@mail.gmail.com>

> > I will install your script on Monday (I have more chances to be at
> > my desk if something goes wrong).
> 
> The current hook ignores the commit subject when scanning for
> PR/BZ #.   It causes that glibc commit no longer updates glibc
> bug report when BZ # is only mentioned in the commit subject.

I assume that that the filing is achieved through the use of
a script set up via the hooks.file-commit-cmd option.

As far as I can tell, and verified by testing, there has been no change
of behavior in this area. The data passed to the script is the body
of the email, which should include the equivalent of a "git show"
of your commit. If the PR number is there, must have been given to
your filing script. That's where I would start looking. It could
be the script missed it for some reason, or that the wrong PR number
was used -- for instance. Otherwise, I'm going to need more information.

-- 
Joel


  reply	other threads:[~2020-08-07 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 15:44 Joel Brobecker
2020-08-07 15:50 ` Joel Brobecker
2020-08-07 16:00   ` Simon Marchi
2020-08-07 16:02     ` Simon Marchi
2020-08-07 16:21       ` Joel Brobecker
2020-08-07 16:27         ` H.J. Lu
2020-08-07 16:44           ` Joel Brobecker [this message]
2020-08-10 16:57         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807164436.GG3362@adacore.com \
    --to=brobecker@adacore.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox