From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id BCA763851C35; Fri, 7 Aug 2020 16:44:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BCA763851C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9CCCB117061; Fri, 7 Aug 2020 12:44:38 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mwzJgAiIaPcU; Fri, 7 Aug 2020 12:44:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6863911705C; Fri, 7 Aug 2020 12:44:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CB5BF82C47; Fri, 7 Aug 2020 09:44:36 -0700 (PDT) Date: Fri, 7 Aug 2020 09:44:36 -0700 From: Joel Brobecker To: "H.J. Lu" Cc: Simon Marchi , Binutils , GDB Subject: Re: FYI: git-hooks update on sourceware.org Message-ID: <20200807164436.GG3362@adacore.com> References: <20200807154423.GB3362@adacore.com> <20200807155017.GC3362@adacore.com> <31207ab5-403b-180f-e74f-9b6e8d1dc5a4@simark.ca> <19669201-5e6f-99ce-a5ba-c91c78616fce@simark.ca> <20200807162118.GF3362@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 16:44:39 -0000 > > I will install your script on Monday (I have more chances to be at > > my desk if something goes wrong). > > The current hook ignores the commit subject when scanning for > PR/BZ #. It causes that glibc commit no longer updates glibc > bug report when BZ # is only mentioned in the commit subject. I assume that that the filing is achieved through the use of a script set up via the hooks.file-commit-cmd option. As far as I can tell, and verified by testing, there has been no change of behavior in this area. The data passed to the script is the body of the email, which should include the equivalent of a "git show" of your commit. If the PR number is there, must have been given to your filing script. That's where I would start looking. It could be the script missed it for some reason, or that the wrong PR number was used -- for instance. Otherwise, I'm going to need more information. -- Joel