From: Kevin Buettner <kevinb@redhat.com>
To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Cc: Felix Willgerodt <felix.willgerodt@intel.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 2/2] Add bfloat16 support for AVX512 register view.
Date: Fri, 24 Jul 2020 11:35:00 -0700 [thread overview]
Message-ID: <20200724113500.6d9070a5@f32-m1.lan> (raw)
In-Reply-To: <20200724085935.2637025-3-felix.willgerodt@intel.com>
On Fri, 24 Jul 2020 10:59:35 +0200
Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> wrote:
> * features/i386/64bit-avx512.c
> (create_feature_i386_64bit_avx512): Add vector v8bf.
> (create_feature_i386_64bit_avx512): Add field v8_bfloat16.
> * features/i386/64bit-avx512.xml: Likewise.
> * features/i386/64bit-sse.c
> (create_feature_i386_64bit_sse): Add vector v8bf.
> (create_feature_i386_64bit_sse): Add field v8_bfloat16.
> * features/i386/64bit-sse.xml: Likewise.
For these ChangeLog entries, I'd prefer to see:
* features/i386/64bit-avx512.xml
(create_feature_i386_64bit_avx512): Add vector v8bf.
(create_feature_i386_64bit_avx512): Add field v8_bfloat16.
* features/i386/64bit-avx512.c: Regenerate.
* features/i386/64bit-sse.xml
(create_feature_i386_64bit_sse): Add vector v8bf.
(create_feature_i386_64bit_sse): Add field v8_bfloat16.
* features/i386/64bit-sse.c: Regenerate.
Otherwise, okay.
(Except for the libiberty and include portions which need approval
from a GCC maintainer.)
Kevin
prev parent reply other threads:[~2020-07-24 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 8:59 [PATCH v2 0/2] avx512 bfloat16 support Felix Willgerodt
2020-07-24 8:59 ` [PATCH v2 1/2] i386-tdep: Fix naming in zmm and ymm type descriptions Felix Willgerodt
2020-07-24 18:19 ` Kevin Buettner
2020-07-28 13:23 ` Kirill Yukhin
2020-07-28 13:43 ` Willgerodt, Felix
2020-07-24 8:59 ` [PATCH v2 2/2] Add bfloat16 support for AVX512 register view Felix Willgerodt
2020-07-24 18:35 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724113500.6d9070a5@f32-m1.lan \
--to=kevinb@redhat.com \
--cc=felix.willgerodt@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox