From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 7D2D53857C64 for ; Fri, 24 Jul 2020 18:35:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7D2D53857C64 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-oIBOjkMlPtqC9bBMJpW4xQ-1; Fri, 24 Jul 2020 14:35:02 -0400 X-MC-Unique: oIBOjkMlPtqC9bBMJpW4xQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23B2880046A; Fri, 24 Jul 2020 18:35:01 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-21.phx2.redhat.com [10.3.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D759E71D31; Fri, 24 Jul 2020 18:35:00 +0000 (UTC) Date: Fri, 24 Jul 2020 11:35:00 -0700 From: Kevin Buettner To: Felix Willgerodt via Gdb-patches Cc: Felix Willgerodt , gcc-patches@gcc.gnu.org Subject: Re: [PATCH v2 2/2] Add bfloat16 support for AVX512 register view. Message-ID: <20200724113500.6d9070a5@f32-m1.lan> In-Reply-To: <20200724085935.2637025-3-felix.willgerodt@intel.com> References: <20200724085935.2637025-1-felix.willgerodt@intel.com> <20200724085935.2637025-3-felix.willgerodt@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 18:35:05 -0000 On Fri, 24 Jul 2020 10:59:35 +0200 Felix Willgerodt via Gdb-patches wrote: > * features/i386/64bit-avx512.c > (create_feature_i386_64bit_avx512): Add vector v8bf. > (create_feature_i386_64bit_avx512): Add field v8_bfloat16. > * features/i386/64bit-avx512.xml: Likewise. > * features/i386/64bit-sse.c > (create_feature_i386_64bit_sse): Add vector v8bf. > (create_feature_i386_64bit_sse): Add field v8_bfloat16. > * features/i386/64bit-sse.xml: Likewise. For these ChangeLog entries, I'd prefer to see: * features/i386/64bit-avx512.xml (create_feature_i386_64bit_avx512): Add vector v8bf. (create_feature_i386_64bit_avx512): Add field v8_bfloat16. * features/i386/64bit-avx512.c: Regenerate. * features/i386/64bit-sse.xml (create_feature_i386_64bit_sse): Add vector v8bf. (create_feature_i386_64bit_sse): Add field v8_bfloat16. * features/i386/64bit-sse.c: Regenerate. Otherwise, okay. (Except for the libiberty and include portions which need approval from a GCC maintainer.) Kevin