From: Joel Brobecker <brobecker@adacore.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: libctf compilation failure on MinGW
Date: Sat, 18 Jul 2020 12:06:24 -0700 [thread overview]
Message-ID: <20200718190624.GB582@adacore.com> (raw)
In-Reply-To: <878sfztabt.fsf@esperi.org.uk>
Hi Nick,
On Sat, Jul 04, 2020 at 07:16:22PM +0100, Nick Alcock wrote:
> On 2 Jul 2020, Eli Zaretskii outgrape:
>
> > We had a conversation about this back in February, AFAIR, and your
> > conclusion was that you'd like to remove those E* constants from the
> > sources, and thus avoid the problem altogether.
> >
> > Did you have time to make those changes since then?
>
> I... tried. It's *so annoying* to use that I'm going to go for your
> original approach, and just #define undefined-on-some-platform E*
> constants as needed. (Maybe I should automate this, and scan *all* E*
> constants used by libctf in configure and define suitable replacements,
> to avoid the whack-a-mole nature of this?)
>
> > GDB is about to branch for the imminent GDB 10.1 release, and
> > currently the problems I described back then are still with us.
>
> Oh, I thought you pushed a fix already! Sorry!
>
> I'll post a fix sticking suitable E* #defines in once I get back from
> holiday on Tuesday.
>
> > we'd like a solution soon, and need to decide whether to go with the
> > same workaround we used for GDB 9.1 or use a better change from you.
>
> I think that workaround is in hindsight better than the change I
> proposed, and should go in trunk. :/
I don't think the fix has been pushed, has it? Would it help if
we pushed the fix we proposed a while back?
--
Joel
prev parent reply other threads:[~2020-07-18 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 13:45 Eli Zaretskii
2020-07-04 18:16 ` Nick Alcock
2020-07-04 18:19 ` Eli Zaretskii
2020-07-18 19:06 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718190624.GB582@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox