From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 040183858D34 for ; Sat, 18 Jul 2020 19:06:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 040183858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D94755611E; Sat, 18 Jul 2020 15:06:26 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XUfISrZKeThA; Sat, 18 Jul 2020 15:06:26 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A78EA5611D; Sat, 18 Jul 2020 15:06:26 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C297683464; Sat, 18 Jul 2020 12:06:24 -0700 (PDT) Date: Sat, 18 Jul 2020 12:06:24 -0700 From: Joel Brobecker To: Nick Alcock Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: libctf compilation failure on MinGW Message-ID: <20200718190624.GB582@adacore.com> References: <83y2o2vxm7.fsf@gnu.org> <878sfztabt.fsf@esperi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878sfztabt.fsf@esperi.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2020 19:06:27 -0000 Hi Nick, On Sat, Jul 04, 2020 at 07:16:22PM +0100, Nick Alcock wrote: > On 2 Jul 2020, Eli Zaretskii outgrape: > > > We had a conversation about this back in February, AFAIR, and your > > conclusion was that you'd like to remove those E* constants from the > > sources, and thus avoid the problem altogether. > > > > Did you have time to make those changes since then? > > I... tried. It's *so annoying* to use that I'm going to go for your > original approach, and just #define undefined-on-some-platform E* > constants as needed. (Maybe I should automate this, and scan *all* E* > constants used by libctf in configure and define suitable replacements, > to avoid the whack-a-mole nature of this?) > > > GDB is about to branch for the imminent GDB 10.1 release, and > > currently the problems I described back then are still with us. > > Oh, I thought you pushed a fix already! Sorry! > > I'll post a fix sticking suitable E* #defines in once I get back from > holiday on Tuesday. > > > we'd like a solution soon, and need to decide whether to go with the > > same workaround we used for GDB 9.1 or use a better change from you. > > I think that workaround is in hindsight better than the change I > proposed, and should go in trunk. :/ I don't think the fix has been pushed, has it? Would it help if we pushed the fix we proposed a while back? -- Joel