From: Luis Machado <luis.machado@linaro.org>
To: gdb-patches@sourceware.org, Alan.Hayward@arm.com
Cc: omair.javaid@linaro.org, catalin.marinas@arm.com,
david.spickett@linaro.org, jose.marchesi@oracle.com
Subject: [PATCH 06/23] Unit tests for gdbserver memory tagging remote packets
Date: Wed, 15 Jul 2020 16:44:56 -0300 [thread overview]
Message-ID: <20200715194513.16641-7-luis.machado@linaro.org> (raw)
In-Reply-To: <20200715194513.16641-1-luis.machado@linaro.org>
Add some unit testing to exercise the functions handling the qMemTags and
QMemTags packets as well as feature support.
gdbserver/ChangeLog:
YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
* server.cc (test_memory_tagging_functions): New function.
(captured_main): Register test_memory_tagging_functions.
---
gdbserver/server.cc | 88 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 88 insertions(+)
diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index 2fb2b399b2..e0a7b55abb 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -3680,6 +3680,91 @@ detach_or_kill_for_exit_cleanup ()
}
}
+#if GDB_SELF_TEST
+
+namespace selftests {
+
+static void
+test_memory_tagging_functions (void)
+{
+ /* Setup testing. */
+ gdb::char_vector packet;
+ gdb::byte_vector tags, bv;
+ std::string expected;
+ packet.resize (32000);
+ CORE_ADDR addr;
+ size_t len;
+
+ /* Test parsing a qMemTags request. */
+
+ /* Invalid request, addr and len unchanged. */
+ addr = 0xff;
+ len = 255;
+ strcpy (packet.data (), "qMemTags_wrong:0,0");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) != 0);
+ SELF_CHECK (addr == 0xff && len == 255);
+
+ /* Valid request, addr and len updated. */
+ addr = 0xff;
+ len = 255;
+ strcpy (packet.data (), "qMemTags:0,0");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) == 0);
+ SELF_CHECK (addr == 0 && len == 0);
+
+ /* Valid request, addr and len updated. */
+ addr = 0;
+ len = 0;
+ strcpy (packet.data (), "qMemTags:deadbeef,ff");
+ SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) == 0);
+ SELF_CHECK (addr == 0xdeadbeef && len == 255);
+
+ /* Test creating a qMemTags reply. */
+
+ /* Non-empty tag data. */
+ bv.resize (0);
+
+ for (int i = 0; i < 5; i++)
+ bv.push_back (i);
+
+ expected = "m0001020304";
+ SELF_CHECK (create_fmemtags_reply (packet.data (), bv) == 0);
+ SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0);
+
+ /* Empty tag data (error). */
+ bv.clear ();
+ SELF_CHECK (create_fmemtags_reply (packet.data (), bv) != 0);
+
+ /* Test parsing a QMemTags request. */
+
+ /* Invalid request and non-empty tag data: addr, len and tags unchanged. */
+ addr = 0xff;
+ len = 255;
+ tags.resize (5);
+ strcpy (packet.data (), "QMemTags_wrong:0,0:");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) != 0);
+ SELF_CHECK (addr == 0xff && len == 255 && tags.size () == 5);
+
+ /* Valid request and empty tag data: addr, len and tags updated. */
+ addr = 0xff;
+ len = 255;
+ tags.resize (5);
+ strcpy (packet.data (), "QMemTags:0,0:");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) == 0);
+ SELF_CHECK (addr == 0 && len == 0 && tags.size () == 0);
+
+ /* Valid request and non-empty tag data: addr, len and tags updated. */
+ addr = 0;
+ len = 0;
+ tags.resize (0);
+ strcpy (packet.data (),
+ "QMemTags:deadbeef,ff:0001020304");
+ SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) == 0);
+ SELF_CHECK (addr == 0xdeadbeef && len == 255 && tags.size () == 5);
+}
+
+} // namespace selftests
+#endif /* GDB_SELF_TEST */
+
/* Main function. This is called by the real "main" function,
wrapped in a TRY_CATCH that handles any uncaught exceptions. */
@@ -3697,6 +3782,9 @@ captured_main (int argc, char *argv[])
bool selftest = false;
#if GDB_SELF_TEST
const char *selftest_filter = NULL;
+
+ selftests::register_test ("remote_memory_tagging",
+ selftests::test_memory_tagging_functions);
#endif
current_directory = getcwd (NULL, 0);
--
2.17.1
next prev parent reply other threads:[~2020-07-15 19:47 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 19:44 [PATCH 00/23] Memory Tagging Support + AArch64 Linux implementation Luis Machado
2020-07-15 19:44 ` [PATCH 01/23] New target methods for memory tagging support Luis Machado
2020-07-15 19:44 ` [PATCH 02/23] New gdbarch memory tagging hooks Luis Machado
2020-07-15 19:44 ` [PATCH 03/23] Add GDB-side remote target support for memory tagging Luis Machado
2020-07-15 19:44 ` [PATCH 04/23] Unit testing for GDB-side remote memory tagging handling Luis Machado
2020-07-15 19:44 ` [PATCH 05/23] GDBserver remote packet support for memory tagging Luis Machado
2020-07-15 19:44 ` Luis Machado [this message]
2020-07-15 19:44 ` [PATCH 07/23] Documentation for memory tagging remote packets Luis Machado
2020-07-17 5:54 ` Eli Zaretskii
2020-07-17 14:20 ` Luis Machado
2020-07-15 19:44 ` [PATCH 08/23] AArch64: Add MTE CPU feature check support Luis Machado
2020-07-15 19:44 ` [PATCH 09/23] AArch64: Add target description/feature for MTE registers Luis Machado
2020-07-15 19:45 ` [PATCH 10/23] AArch64: Add MTE register set support for GDB and gdbserver Luis Machado
2020-07-15 19:45 ` [PATCH 11/23] AArch64: Add MTE ptrace requests Luis Machado
2020-07-15 19:45 ` [PATCH 12/23] AArch64: Implement memory tagging target methods for AArch64 Luis Machado
2020-07-15 19:45 ` [PATCH 13/23] Refactor parsing of /proc/<pid>/smaps Luis Machado
2020-07-15 19:45 ` [PATCH 14/23] AArch64: Implement the memory tagging gdbarch hooks Luis Machado
2020-07-15 19:45 ` [PATCH 15/23] AArch64: Add unit testing for logical tag set/get operations Luis Machado
2020-07-15 19:45 ` [PATCH 16/23] AArch64: Report tag violation error information Luis Machado
2020-07-15 19:45 ` [PATCH 17/23] AArch64: Add gdbserver MTE support Luis Machado
2020-07-15 19:45 ` [PATCH 18/23] New mtag commands Luis Machado
2020-07-15 19:45 ` [PATCH 19/23] Documentation for the new " Luis Machado
2020-07-17 6:11 ` Eli Zaretskii
2020-07-17 14:20 ` Luis Machado
2020-07-17 14:29 ` Eli Zaretskii
2020-07-17 15:08 ` Luis Machado
2020-07-15 19:45 ` [PATCH 20/23] Extend "x" and "print" commands to support memory tagging Luis Machado
2020-07-15 19:45 ` [PATCH 21/23] Document new "x" and "print" memory tagging extensions Luis Machado
2020-07-17 6:16 ` Eli Zaretskii
2020-07-17 14:20 ` Luis Machado
2020-07-17 14:31 ` Eli Zaretskii
2020-07-15 19:45 ` [PATCH 22/23] Add NEWS entry Luis Machado
2020-07-17 6:18 ` Eli Zaretskii
2020-07-17 14:20 ` Luis Machado
2020-07-15 19:45 ` [PATCH 23/23] Add memory tagging testcases Luis Machado
2020-07-16 16:49 ` [PATCH 00/23] Memory Tagging Support + AArch64 Linux implementation Alan Hayward
2020-07-17 12:33 ` Luis Machado
2020-07-17 22:02 ` John Baldwin
2020-07-23 13:59 ` Luis Machado
2020-07-23 16:48 ` John Baldwin
2020-07-24 16:10 ` David Spickett
2020-07-23 14:59 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715194513.16641-7-luis.machado@linaro.org \
--to=luis.machado@linaro.org \
--cc=Alan.Hayward@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david.spickett@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=omair.javaid@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox