From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 13E1B383E83C for ; Wed, 15 Jul 2020 19:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 13E1B383E83C Received: by mail-qt1-x842.google.com with SMTP id i3so2701697qtq.13 for ; Wed, 15 Jul 2020 12:47:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BpzLiPOvmXENMk1RcA+kvpW6Si+nrI3ZN4Eai4DkMlQ=; b=Ih4OIIOi99y9wvpiIANzyG9MKtctaN6PRv96StzscAx/DHRuGjw9KW2w9dF8lFj/Pu 2pE1hRknNvp13i0q5CHFR34pQ+i+Uipql8s4f03/2mJQDgdqgl/kb7wSmIIIgJmQII75 lgjsp0axKk/64jFXDoF2bR4ZKP3UIem6sL3Yy85J8BGC2DHrdjLRjxmxv2iNZFLcEQKE 2hx1TOunaGseSqVfPCe1+zBY4gLF2QFp6t8YXfwH8++bDDwyLitHQnmsTEMEwdIGRgtJ 5vmwOuEPaGITGk9X9y0c4SThCwepC6T6Ay75FurcpoHIO4cev8j2FJ1to81UIoarJxS0 j4ZQ== X-Gm-Message-State: AOAM533ql3yQWBIYJS3bT8tO/mPk+EPyWPFO3YNoaXaSkkJXCZLqtbKf FNGN6uwExV76u7Gxu+f6nJU7es1fKgntDQ== X-Google-Smtp-Source: ABdhPJwUK8/7Z3WOW5A3EMNUmWfRpQdXETvqwUGIqLtgXrbyN4m+qQ+RXcutBRPIozfHzojSvDRxDw== X-Received: by 2002:ac8:27c9:: with SMTP id x9mr1583954qtx.172.1594842428384; Wed, 15 Jul 2020 12:47:08 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:8283:82c3:9daa:7611:ebe6:931]) by smtp.gmail.com with ESMTPSA id z18sm4340537qta.51.2020.07.15.12.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 12:47:07 -0700 (PDT) From: Luis Machado To: gdb-patches@sourceware.org, Alan.Hayward@arm.com Cc: omair.javaid@linaro.org, catalin.marinas@arm.com, david.spickett@linaro.org, jose.marchesi@oracle.com Subject: [PATCH 06/23] Unit tests for gdbserver memory tagging remote packets Date: Wed, 15 Jul 2020 16:44:56 -0300 Message-Id: <20200715194513.16641-7-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200715194513.16641-1-luis.machado@linaro.org> References: <20200715194513.16641-1-luis.machado@linaro.org> X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 19:47:10 -0000 Add some unit testing to exercise the functions handling the qMemTags and QMemTags packets as well as feature support. gdbserver/ChangeLog: YYYY-MM-DD Luis Machado * server.cc (test_memory_tagging_functions): New function. (captured_main): Register test_memory_tagging_functions. --- gdbserver/server.cc | 88 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 2fb2b399b2..e0a7b55abb 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -3680,6 +3680,91 @@ detach_or_kill_for_exit_cleanup () } } +#if GDB_SELF_TEST + +namespace selftests { + +static void +test_memory_tagging_functions (void) +{ + /* Setup testing. */ + gdb::char_vector packet; + gdb::byte_vector tags, bv; + std::string expected; + packet.resize (32000); + CORE_ADDR addr; + size_t len; + + /* Test parsing a qMemTags request. */ + + /* Invalid request, addr and len unchanged. */ + addr = 0xff; + len = 255; + strcpy (packet.data (), "qMemTags_wrong:0,0"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) != 0); + SELF_CHECK (addr == 0xff && len == 255); + + /* Valid request, addr and len updated. */ + addr = 0xff; + len = 255; + strcpy (packet.data (), "qMemTags:0,0"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) == 0); + SELF_CHECK (addr == 0 && len == 0); + + /* Valid request, addr and len updated. */ + addr = 0; + len = 0; + strcpy (packet.data (), "qMemTags:deadbeef,ff"); + SELF_CHECK (parse_fmemtags_request (packet.data (), &addr, &len) == 0); + SELF_CHECK (addr == 0xdeadbeef && len == 255); + + /* Test creating a qMemTags reply. */ + + /* Non-empty tag data. */ + bv.resize (0); + + for (int i = 0; i < 5; i++) + bv.push_back (i); + + expected = "m0001020304"; + SELF_CHECK (create_fmemtags_reply (packet.data (), bv) == 0); + SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); + + /* Empty tag data (error). */ + bv.clear (); + SELF_CHECK (create_fmemtags_reply (packet.data (), bv) != 0); + + /* Test parsing a QMemTags request. */ + + /* Invalid request and non-empty tag data: addr, len and tags unchanged. */ + addr = 0xff; + len = 255; + tags.resize (5); + strcpy (packet.data (), "QMemTags_wrong:0,0:"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) != 0); + SELF_CHECK (addr == 0xff && len == 255 && tags.size () == 5); + + /* Valid request and empty tag data: addr, len and tags updated. */ + addr = 0xff; + len = 255; + tags.resize (5); + strcpy (packet.data (), "QMemTags:0,0:"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) == 0); + SELF_CHECK (addr == 0 && len == 0 && tags.size () == 0); + + /* Valid request and non-empty tag data: addr, len and tags updated. */ + addr = 0; + len = 0; + tags.resize (0); + strcpy (packet.data (), + "QMemTags:deadbeef,ff:0001020304"); + SELF_CHECK (parse_smemtags_request (packet.data (), &addr, &len, tags) == 0); + SELF_CHECK (addr == 0xdeadbeef && len == 255 && tags.size () == 5); +} + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + /* Main function. This is called by the real "main" function, wrapped in a TRY_CATCH that handles any uncaught exceptions. */ @@ -3697,6 +3782,9 @@ captured_main (int argc, char *argv[]) bool selftest = false; #if GDB_SELF_TEST const char *selftest_filter = NULL; + + selftests::register_test ("remote_memory_tagging", + selftests::test_memory_tagging_functions); #endif current_directory = getcwd (NULL, 0); -- 2.17.1