Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix -Wstring-compare testcase build failure
Date: Fri, 26 Jun 2020 14:54:20 +0100	[thread overview]
Message-ID: <20200626135420.GA17944@blade.nx> (raw)
In-Reply-To: <14a03347-e8fe-b642-36b2-ff74ae17c618@palves.net>

Pedro Alves wrote:
> On 6/26/20 2:05 PM, Gary Benson wrote:
> 
> > diff --git a/gdb/testsuite/gdb.cp/try_catch.exp b/gdb/testsuite/gdb.cp/try_catch.exp
> > index fb53294..e4da885 100644
> > --- a/gdb/testsuite/gdb.cp/try_catch.exp
> > +++ b/gdb/testsuite/gdb.cp/try_catch.exp
> > @@ -63,5 +63,8 @@ gdb_continue_to_breakpoint "marker 3-throw"
> >  gdb_breakpoint [gdb_get_line_number "marker 3-catch"]
> >  gdb_continue_to_breakpoint "marker 3-catch"
> >  
> > +gdb_breakpoint [gdb_get_line_number "marker test-complete"]
> > +gdb_test "p test" "= true"
> > +
> 
> You need to continue the program to the breakpoint too.
> I.e., you're missing a
> 
>   gdb_continue_to_breakpoint "marker test-complete"
> 
> line.
> 
> OK with that change.

Fixed and pushed, thanks Pedro.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat



      reply	other threads:[~2020-06-26 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 14:57 [PATCH] " Gary Benson
2020-06-23 15:57 ` Pedro Alves
2020-06-26 13:05   ` [PATCH v2] " Gary Benson
2020-06-26 13:19     ` Pedro Alves
2020-06-26 13:54       ` Gary Benson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626135420.GA17944@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox