From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 45C943858D34 for ; Fri, 26 Jun 2020 13:54:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45C943858D34 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-Zh_z7SLuP7-9MnvDUZePkw-1; Fri, 26 Jun 2020 09:54:23 -0400 X-MC-Unique: Zh_z7SLuP7-9MnvDUZePkw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 291571800D4A; Fri, 26 Jun 2020 13:54:22 +0000 (UTC) Received: from blade.nx (ovpn-114-112.ams2.redhat.com [10.36.114.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFE1F5D9CA; Fri, 26 Jun 2020 13:54:21 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id E7B9F816CCA9; Fri, 26 Jun 2020 14:54:20 +0100 (BST) Date: Fri, 26 Jun 2020 14:54:20 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix -Wstring-compare testcase build failure Message-ID: <20200626135420.GA17944@blade.nx> References: <1593176700-16489-1-git-send-email-gbenson@redhat.com> <14a03347-e8fe-b642-36b2-ff74ae17c618@palves.net> MIME-Version: 1.0 In-Reply-To: <14a03347-e8fe-b642-36b2-ff74ae17c618@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 13:54:26 -0000 Pedro Alves wrote: > On 6/26/20 2:05 PM, Gary Benson wrote: > > > diff --git a/gdb/testsuite/gdb.cp/try_catch.exp b/gdb/testsuite/gdb.cp/try_catch.exp > > index fb53294..e4da885 100644 > > --- a/gdb/testsuite/gdb.cp/try_catch.exp > > +++ b/gdb/testsuite/gdb.cp/try_catch.exp > > @@ -63,5 +63,8 @@ gdb_continue_to_breakpoint "marker 3-throw" > > gdb_breakpoint [gdb_get_line_number "marker 3-catch"] > > gdb_continue_to_breakpoint "marker 3-catch" > > > > +gdb_breakpoint [gdb_get_line_number "marker test-complete"] > > +gdb_test "p test" "= true" > > + > > You need to continue the program to the breakpoint too. > I.e., you're missing a > > gdb_continue_to_breakpoint "marker test-complete" > > line. > > OK with that change. Fixed and pushed, thanks Pedro. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat