Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Heiher <r@hev.cc>
To: gdb-patches@sourceware.org
Cc: Heiher <r@hev.cc>
Subject: [PATCH] Fix read and access watchpoint can't stop
Date: Thu, 18 Jun 2020 00:17:08 +0800	[thread overview]
Message-ID: <20200617161708.15710-1-r@hev.cc> (raw)

gdb/ChangeLog:

2020-06-17  Heiher  <r@hev.cc>

	* breakpoint.c (bpstat_check_watchpoint):
	Fix read and access watchpoint can't stop.
---
 gdb/ChangeLog    | 5 +++++
 gdb/breakpoint.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0a2dc2275d..ecd2ef7c65 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-06-17  Heiher  <r@hev.cc>
+
+	* breakpoint.c (bpstat_check_watchpoint):
+	Fix read and access watchpoint can't stop.
+
 2020-06-17  Heiher  <r@hev.cc>
 
 	* mips-linux-nat.c (mips_linux_nat_target::can_use_hw_breakpoint):
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index aead882acd..669ae191ab 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -4952,7 +4952,7 @@ bpstat_check_watchpoint (bpstat bs)
 	   this watchpoint.  */
 	must_check_value = 1;
       else if (b->watchpoint_triggered == watch_triggered_unknown
-	       && b->type == bp_hardware_watchpoint)
+	       && is_hardware_watchpoint (bs->breakpoint_at))
 	/* We were stopped by a hardware watchpoint, but the target could
 	   not report the data address.  We must check the watchpoint's
 	   value.  Access and read watchpoints are out of luck; without
-- 
2.27.0



             reply	other threads:[~2020-06-17 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17 16:17 Heiher [this message]
2020-06-17 16:38 ` Eli Zaretskii
2020-06-18  2:05   ` Hev
2020-06-18 13:35     ` Eli Zaretskii
2020-06-18 15:35       ` Hev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617161708.15710-1-r@hev.cc \
    --to=r@hev.cc \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox