From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by sourceware.org (Postfix) with ESMTPS id 14E4B3890409 for ; Wed, 17 Jun 2020 16:17:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14E4B3890409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hev.cc Authentication-Results: sourceware.org; spf=none smtp.mailfrom=r@hev.cc Received: by mail-pf1-x442.google.com with SMTP id a127so1348789pfa.12 for ; Wed, 17 Jun 2020 09:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hev-cc.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PTS4T64oHiVbohcIQfSA4TsNumhrmxFsT/+T71AmA+U=; b=re3fzEmEZNwt53Zw7JHZV8YpLDZP0WPlAtbe5lPagGpkFbCYFxll+WHc5txROwrbeW NblUJfGiXH/lMaZsY4pDasy6k7JzoIWyXGL84w/9OfCKoqcCvbNnHopRgiUtRuuWCNbh X3GQ162svIwl5KwQIdTtl9MBdeXa61mHWXHQRvtcYPmMd4OdyDnILBr3SEqQbIlkCvxU P+fXJge5zo8SxwlVRds7BDOMudg+jI5iDl2Ofuew59M2ssbfwFwaXkG0gSGL/hQ7Ru1g nVDytr8UL79B+CHVsE2cbfN3ltkZjq9AVdvLQeSWQT54CaXQu0vL668p9LSQyhDXl5eR hVIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PTS4T64oHiVbohcIQfSA4TsNumhrmxFsT/+T71AmA+U=; b=YRQZlFvVEecQzUgnrlT+qkdeidCRIzov1DrVQxFVQ2XxhlTnFk3Y6BbjasWEhsoS/A Ct0pppwoRvUtx+pXGD5v932EK4uDb8c0to7OyQcSnAkQ38jTo0AN2WVRHfkBw29a5R6m TwkS5HqsMOiJmX7HBdyvhy1VdbVaWPLe3ZK4ewG9zImHC1B8FAv/3UYLLQn6ATqf1a1k rrDrGCD9q59vfiPCVHfiAmhheKe3YypxCB5aLRmrNxGLSExT1BusSCfORWd+E1R8rqX7 igIdYJOzS8dl6S3wz8vPeO3odoa1z4laKYwdJHLSS3DpQl/SVVwTvk6UMGhhkASk2uh4 F/lQ== X-Gm-Message-State: AOAM532KafO2D0dAQKFgx0oQCABtlEyR/d7veIm0ttXsOEstHbG5lLR+ h02BsZJQDRCJJ+kRlHv6mpOCTlc4KHyfAw== X-Google-Smtp-Source: ABdhPJxsUZlQGeCDSIjSKL+cY56i0204UNHQWSo/lyoUBK5UwIn7nsQkj3GODPmlfYlhBgLUCUYTxA== X-Received: by 2002:a63:5d55:: with SMTP id o21mr6970760pgm.58.1592410648792; Wed, 17 Jun 2020 09:17:28 -0700 (PDT) Received: from localhost.localdomain ([45.77.13.216]) by smtp.gmail.com with ESMTPSA id 140sm311715pfz.154.2020.06.17.09.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 09:17:28 -0700 (PDT) From: Heiher To: gdb-patches@sourceware.org Cc: Heiher Subject: [PATCH] Fix read and access watchpoint can't stop Date: Thu, 18 Jun 2020 00:17:08 +0800 Message-Id: <20200617161708.15710-1-r@hev.cc> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 16:17:31 -0000 gdb/ChangeLog: 2020-06-17 Heiher * breakpoint.c (bpstat_check_watchpoint): Fix read and access watchpoint can't stop. --- gdb/ChangeLog | 5 +++++ gdb/breakpoint.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0a2dc2275d..ecd2ef7c65 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-06-17 Heiher + + * breakpoint.c (bpstat_check_watchpoint): + Fix read and access watchpoint can't stop. + 2020-06-17 Heiher * mips-linux-nat.c (mips_linux_nat_target::can_use_hw_breakpoint): diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index aead882acd..669ae191ab 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -4952,7 +4952,7 @@ bpstat_check_watchpoint (bpstat bs) this watchpoint. */ must_check_value = 1; else if (b->watchpoint_triggered == watch_triggered_unknown - && b->type == bp_hardware_watchpoint) + && is_hardware_watchpoint (bs->breakpoint_at)) /* We were stopped by a hardware watchpoint, but the target could not report the data address. We must check the watchpoint's value. Access and read watchpoints are out of luck; without -- 2.27.0