From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Sergei Trofimovich <slyfox@gentoo.org>,
Sergei Trofimovich <siarheit@google.com>
Subject: Re: [PATCH] gdb: fix IA64 build failure of linux-nat
Date: Tue, 19 May 2020 15:00:41 -0700 [thread overview]
Message-ID: <20200519150041.13df2b38@f31-4.lan> (raw)
In-Reply-To: <20200519212710.1417100-1-slyfox@gentoo.org>
On Tue, 19 May 2020 22:27:10 +0100
Sergei Trofimovich via Gdb-patches <gdb-patches@sourceware.org> wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> On IA64 built failed as:
>
> ```
> ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope
> 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch))
> | ^~~~~~~~~~~~~~~~
> ```
>
> The fix includes "gdbarch.h" header where symbol is declared.
>
> * gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used
> 'gdbarch_num_regs'.
Okay, but please capitalize "include" in the ChangeLog entry prior
to pushing this change.
Kevin
next prev parent reply other threads:[~2020-05-19 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 21:27 Sergei Trofimovich
2020-05-19 22:00 ` Kevin Buettner [this message]
2020-08-16 8:45 ` Sergei Trofimovich
2020-08-16 21:51 ` Simon Marchi
2020-08-17 8:54 ` Tom de Vries
2020-08-17 8:21 ` Simon Marchi
2020-08-17 18:59 ` Sergei Trofimovich
2020-08-18 8:46 ` Tom de Vries
2020-08-17 20:57 ` Sergei Trofimovich
2020-08-17 21:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519150041.13df2b38@f31-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siarheit@google.com \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox