From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kevinb@redhat.com>
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120])
 by sourceware.org (Postfix) with ESMTP id 59ECB3851C0F
 for <gdb-patches@sourceware.org>; Tue, 19 May 2020 22:00:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59ECB3851C0F
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-235-1vctHj8VP7eLmScaulHvGw-1; Tue, 19 May 2020 18:00:43 -0400
X-MC-Unique: 1vctHj8VP7eLmScaulHvGw-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EF8B100A8E9;
 Tue, 19 May 2020 22:00:42 +0000 (UTC)
Received: from f31-4.lan (ovpn-115-18.phx2.redhat.com [10.3.115.18])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id CCA7D5D9CD;
 Tue, 19 May 2020 22:00:41 +0000 (UTC)
Date: Tue, 19 May 2020 15:00:41 -0700
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Sergei Trofimovich <slyfox@gentoo.org>, Sergei Trofimovich
 <siarheit@google.com>
Subject: Re: [PATCH] gdb: fix IA64 build failure of linux-nat
Message-ID: <20200519150041.13df2b38@f31-4.lan>
In-Reply-To: <20200519212710.1417100-1-slyfox@gentoo.org>
References: <20200519212710.1417100-1-slyfox@gentoo.org>
Organization: Red Hat
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 22:00:46 -0000

On Tue, 19 May 2020 22:27:10 +0100
Sergei Trofimovich via Gdb-patches <gdb-patches@sourceware.org> wrote:

> From: Sergei Trofimovich <siarheit@google.com>
> 
> On IA64 built failed as:
> 
> ```
> ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope
>   352 |   if (regno < 0 || regno >= gdbarch_num_regs (gdbarch))
>       |                             ^~~~~~~~~~~~~~~~
> ```
> 
> The fix includes "gdbarch.h" header where symbol is declared.
> 
> 	* gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used
> 	'gdbarch_num_regs'.

Okay, but please capitalize "include" in the ChangeLog entry prior
to pushing this change.

Kevin