Re: [PATCH 7/7] gdbserver: remove support for ARM/WinCE

[Kevin Buettner <kevinb@redhat.com>]

On Thu, 14 May 2020 19:14:23 -0400
Simon Marchi <simark@simark.ca> wrote:

> On 2020-05-14 4:30 p.m., Kevin Buettner via Gdb-patches wrote:
> > Hi Simon,
> > 
> > Just one nit, maybe...
> > 
[...]
> >> +  {  
> > 
> > I think this brace and the matching one later on can be removed, with
> > a corresponding reduction in indent level for the enclosed block.
[...]
> >> +  }  
> > 
> > I think that's the matching brace, above.
> > 
> > Kevin
> >   
> 
> Thanks for the suggestion.  I tried this, but just removing the braces leads to this error:
> 
>   CXX    win32-low.o
> cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid for C/ObjC but not for C++
> /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc: In function ‘int get_child_debug_event(DWORD*, target_waitstatus*)’:
> /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1449:2: error: jump to label ‘gotevent’
>  1449 |  gotevent:
>       |  ^~~~~~~~
> /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1414:12: note:   from here
>  1414 |       goto gotevent;
>       |            ^~~~~~~~
> /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1418:33: note:   crosses initialization of ‘gdb::optional<windows_nat::pending_stop> stop’
>  1418 |     gdb::optional<pending_stop> stop = fetch_pending_stop (debug_threads);
>       |                                 ^~~~
> 
> So it would require other changes.  I'd rather keep this patch trivial, just removing the ifdefs,
> and keep this other change for another time.

Agreed.

Kevin