From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id B85E338708E6 for ; Fri, 15 May 2020 01:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B85E338708E6 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-77-lg6zxYf7Noq-kGnoIJbtyA-1; Thu, 14 May 2020 21:03:13 -0400 X-MC-Unique: lg6zxYf7Noq-kGnoIJbtyA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABB668018AC; Fri, 15 May 2020 01:03:12 +0000 (UTC) Received: from f31-4.lan (ovpn-112-112.phx2.redhat.com [10.3.112.112]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66E7A99ED; Fri, 15 May 2020 01:03:12 +0000 (UTC) Date: Thu, 14 May 2020 18:03:11 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH 7/7] gdbserver: remove support for ARM/WinCE Message-ID: <20200514180311.6baba6d7@f31-4.lan> In-Reply-To: <9d88e2ba-3edd-7b7f-f88a-618f400b5a39@simark.ca> References: <20200514174359.2272960-1-simon.marchi@efficios.com> <20200514190537.2321826-8-simon.marchi@efficios.com> <20200514133049.2297a58a@f31-4.lan> <9d88e2ba-3edd-7b7f-f88a-618f400b5a39@simark.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 01:03:26 -0000 On Thu, 14 May 2020 19:14:23 -0400 Simon Marchi wrote: > On 2020-05-14 4:30 p.m., Kevin Buettner via Gdb-patches wrote: > > Hi Simon, > >=20 > > Just one nit, maybe... > >=20 [...] > >> + { =20 > >=20 > > I think this brace and the matching one later on can be removed, with > > a corresponding reduction in indent level for the enclosed block. [...] > >> + } =20 > >=20 > > I think that's the matching brace, above. > >=20 > > Kevin > > =20 >=20 > Thanks for the suggestion. I tried this, but just removing the braces le= ads to this error: >=20 > CXX win32-low.o > cc1plus: warning: command line option =E2=80=98-Wmissing-prototypes=E2=80= =99 is valid for C/ObjC but not for C++ > /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc: In function =E2=80= =98int get_child_debug_event(DWORD*, target_waitstatus*)=E2=80=99: > /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1449:2: error: jump= to label =E2=80=98gotevent=E2=80=99 > 1449 | gotevent: > | ^~~~~~~~ > /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1414:12: note: fr= om here > 1414 | goto gotevent; > | ^~~~~~~~ > /home/smarchi/src/binutils-gdb/gdbserver/win32-low.cc:1418:33: note: cr= osses initialization of =E2=80=98gdb::optional s= top=E2=80=99 > 1418 | gdb::optional stop =3D fetch_pending_stop (debu= g_threads); > | ^~~~ >=20 > So it would require other changes. I'd rather keep this patch trivial, j= ust removing the ifdefs, > and keep this other change for another time. Agreed. Kevin