Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 0/7] Make gdbarch.sh shellcheck-clean
Date: Tue, 28 Apr 2020 17:46:48 -0400	[thread overview]
Message-ID: <20200428214655.3255454-1-simon.marchi@efficios.com> (raw)

I ran shellcheck on gdbarch.sh and addressed all the warnings.  It
didn't catch anything serious, but I think it's good to have it clean
anyway, so we can catch potential problems in future changes we do to
this file.

Simon Marchi (7):
  gdb: fix shellcheck warnings SC2059 (variables in printf format
    string) in gdbarch.sh
  gdb: fix shellcheck warnings SC2086 (missing double quotes) in
    gdbarch.sh
  gdb: fix shellcheck warnings SC2006 (use $() instead of ``) in
    gdbarch.sh
  gdb: fix shellcheck warnings SC2166 (&& and !! instead of -a and -o)
    in gdbarch.sh
  gdb: fix shellcheck warnings SC2034 (unused variable)  in gdbarch.sh
  gdb: fix shellcheck warnings SC2154 (referenced but not assigned) in
    gdbarch.sh
  gdb: silence shellcheck warning SC2162 (use read -r) in gdbarch.sh

 gdb/gdbarch.sh | 178 ++++++++++++++++++++++---------------------------
 1 file changed, 81 insertions(+), 97 deletions(-)

-- 
2.26.2



             reply	other threads:[~2020-04-28 21:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 21:46 Simon Marchi [this message]
2020-04-28 21:46 ` [PATCH 1/7] gdb: fix shellcheck warnings SC2059 (variables in printf format string) in gdbarch.sh Simon Marchi
2020-04-28 21:46 ` [PATCH 2/7] gdb: fix shellcheck warnings SC2086 (missing double quotes) " Simon Marchi
2020-04-28 21:46 ` [PATCH 3/7] gdb: fix shellcheck warnings SC2006 (use $() instead of ``) " Simon Marchi
2020-04-28 21:46 ` [PATCH 4/7] gdb: fix shellcheck warnings SC2166 (&& and !! instead of -a and -o) " Simon Marchi
2020-04-28 21:46 ` [PATCH 5/7] gdb: fix shellcheck warnings SC2034 (unused variable) " Simon Marchi
2020-04-28 21:46 ` [PATCH 6/7] gdb: fix shellcheck warnings SC2154 (referenced but not assigned) " Simon Marchi
2020-04-28 21:46 ` [PATCH 7/7] gdb: silence shellcheck warning SC2162 (use read -r) " Simon Marchi
2020-04-29 21:08 ` [PATCH 0/7] Make gdbarch.sh shellcheck-clean Tom Tromey
2020-04-30  0:34   ` Simon Marchi
2020-04-30 14:25     ` Tom Tromey
2020-04-30 15:48       ` Simon Marchi
2020-05-07  1:59         ` Tom Tromey
2020-05-10 18:57   ` Pedro Alves
2020-05-10 21:36     ` Simon Marchi
2020-05-11 16:55     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428214655.3255454-1-simon.marchi@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox