From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 60B873851C12 for ; Tue, 28 Apr 2020 21:47:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60B873851C12 X-ASG-Debug-ID: 1588110422-0c856e18f3114d080001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id O71LO9DSXNNVMVu9 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Apr 2020 17:47:02 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from localhost.localdomain (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 100CB441B21; Tue, 28 Apr 2020 17:47:02 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-164-54.qc.cable.ebox.net[192.222.164.54] X-Barracuda-Apparent-Source-IP: 192.222.164.54 X-Barracuda-RBL-IP: 192.222.164.54 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 0/7] Make gdbarch.sh shellcheck-clean Date: Tue, 28 Apr 2020 17:46:48 -0400 X-ASG-Orig-Subj: [PATCH 0/7] Make gdbarch.sh shellcheck-clean Message-Id: <20200428214655.3255454-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1588110422 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 966 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.81496 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-28.7 required=5.0 tests=BAYES_00, GIT_PATCH_2, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 21:47:06 -0000 I ran shellcheck on gdbarch.sh and addressed all the warnings. It didn't catch anything serious, but I think it's good to have it clean anyway, so we can catch potential problems in future changes we do to this file. Simon Marchi (7): gdb: fix shellcheck warnings SC2059 (variables in printf format string) in gdbarch.sh gdb: fix shellcheck warnings SC2086 (missing double quotes) in gdbarch.sh gdb: fix shellcheck warnings SC2006 (use $() instead of ``) in gdbarch.sh gdb: fix shellcheck warnings SC2166 (&& and !! instead of -a and -o) in gdbarch.sh gdb: fix shellcheck warnings SC2034 (unused variable) in gdbarch.sh gdb: fix shellcheck warnings SC2154 (referenced but not assigned) in gdbarch.sh gdb: silence shellcheck warning SC2162 (use read -r) in gdbarch.sh gdb/gdbarch.sh | 178 ++++++++++++++++++++++--------------------------- 1 file changed, 81 insertions(+), 97 deletions(-) -- 2.26.2