* [committed][gdb/testsuite] Fix -readnow FAIL in gdb.base/style.exp
@ 2020-04-10 7:51 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2020-04-10 7:51 UTC (permalink / raw)
To: gdb-patches
Hi,
When running test-case gdb.base/style.exp with target board readnow, we run
into:
...
FAIL: gdb.base/style.exp: filename is styled when loading symbol file
...
The problem is that with -readnow, an extra "Expanding full symbols" message
is generated:
...
(gdb) file $file^M
Reading symbols from $file...^M
Expanding full symbols from $file...^M
(gdb) FAIL: gdb.base/style.exp: filename is styled when loading symbol file
...
and the test does not expect this message.
Fix this by expecting the additional message for -readnow.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix -readnow FAIL in gdb.base/style.exp
gdb/testsuite/ChangeLog:
2020-04-10 Tom de Vries <tdevries@suse.de>
* gdb.base/style.exp: Expect "Expanding full symbols" message for
-readnow.
---
gdb/testsuite/gdb.base/style.exp | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/style.exp b/gdb/testsuite/gdb.base/style.exp
index 1071b023aa..129f1746a3 100644
--- a/gdb/testsuite/gdb.base/style.exp
+++ b/gdb/testsuite/gdb.base/style.exp
@@ -34,6 +34,8 @@ save_vars { env(TERM) } {
return -1
}
+ set readnow [readnow]
+
if {![runto_main]} {
fail "style tests failed"
return
@@ -140,8 +142,15 @@ save_vars { env(TERM) } {
]
set quoted [string_to_regexp $binfile]
+ set pass_re "Reading symbols from [style $quoted file]\.\.\."
+ if { $readnow } {
+ set pass_re \
+ [multi_line \
+ $pass_re \
+ "Expanding full symbols from [style $quoted file]\.\.\."]
+ }
gdb_test "file $binfile" \
- "Reading symbols from [style $quoted file]..." \
+ $pass_re \
"filename is styled when loading symbol file"
gdb_test "pwd" "Working directory [style .*? file].*"
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-10 7:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 7:51 [committed][gdb/testsuite] Fix -readnow FAIL in gdb.base/style.exp Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox