* [committed][gdb/testsuite] Fix tcl error in cached_file
@ 2020-03-09 14:34 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2020-03-09 14:34 UTC (permalink / raw)
To: gdb-patches
Hi,
When trying to run tests using target board cc-with-dwz after a clean build, I
run into:
...
ERROR: tcl error sourcing board description file for target cc-with-tweaks.exp.
couldn't open "build/gdb/testsuite/cache/gdb.sh.17028": \
no such file or directory
couldn't open "build/gdb/testsuite/cache/gdb.sh.17028": \
no such file or directory
while executing
"open $tmp_filename w"
(procedure "cached_file" line 9)
invoked from within
"cached_file gdb.sh "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS \"\$@\"" 1"
...
The problem is that cached_file is trying to create a file
build/gdb/testsuite/cache/gdb.sh.17028 in a non-existing directory.
Fix this by creating the cache dir in cached_file.
Tested on x86_64-linux, with target board cc-with-tweaks, and native.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Fix tcl error in cached_file
gdb/testsuite/ChangeLog:
2020-03-09 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (cached_file): Create cache dir.
---
gdb/testsuite/lib/gdb.exp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 55e58584c8..9614e8dc87 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4958,6 +4958,9 @@ proc cached_file { filename txt {executable 0}} {
return $filename
}
+ set dir [file dirname $filename]
+ file mkdir $dir
+
set tmp_filename $filename.[pid]
set fd [open $tmp_filename w]
puts $fd $txt
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-09 14:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-09 14:34 [committed][gdb/testsuite] Fix tcl error in cached_file Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox