Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho)
Cc: gdb-patches@sourceware.org, ulrich.weigand@de.ibm.com,
	       rcardoso@linux.ibm.com
Subject: Re: [PATCH v2 1/3] Add low_new_clone method to linux_nat_target.
Date: Mon, 17 Feb 2020 17:49:00 -0000	[thread overview]
Message-ID: <20200217174931.925CFD802EA@oc3748833570.ibm.com> (raw)
In-Reply-To: <20200214205443.1073579-2-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Feb 14, 2020 05:54:41 PM

Pedro Franco de Carvalho wrote:

> This patch adds a low_new_clone method to linux_nat_target, called after
> a PTRACE_EVENT_CLONE is detected, similar to how low_new_fork is called
> after PTRACE_EVENT_(V)FORK.
> 
> This is useful for targets that need to copy state associated with a
> thread that is inherited across clones.

Given the discussion we had last year, this is really required for a
correct Power implementation of watchpoints.  Given that the implementation
in common code is straightforward, I this this is fine.

> 	* linux-nat.h (low_new_clone): New method.
> 	* linux-nat.c (linux_handle_extended_wait): Call low_new_clone.

OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2020-02-17 17:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 20:55 [PATCH v2 0/3] low_new_clone in linux-nat.c and powerpc watchpoint fixes Pedro Franco de Carvalho
2020-02-14 20:55 ` [PATCH v2 1/3] Add low_new_clone method to linux_nat_target Pedro Franco de Carvalho
2020-02-17 17:49   ` Ulrich Weigand [this message]
2020-02-14 20:55 ` [PATCH v2 2/3] [PowerPC] Move up some register access routines Pedro Franco de Carvalho
2020-02-17 17:48   ` Ulrich Weigand
2020-02-14 20:55 ` [PATCH v2 3/3] [PowerPC] Fix debug register issues in ppc-linux-nat Pedro Franco de Carvalho
2020-02-17 17:47   ` Ulrich Weigand
2020-02-18 20:31     ` Pedro Franco de Carvalho
2020-02-19 13:46       ` Ulrich Weigand
2020-03-13 20:19     ` Pedro Franco de Carvalho
2020-03-27 18:50       ` Pedro Franco de Carvalho
2020-03-27 18:54         ` [PATCH] " Pedro Franco de Carvalho
2020-03-30 13:04           ` Ulrich Weigand
2020-03-30 13:03         ` [PATCH v2 3/3] " Ulrich Weigand
2020-03-30 15:13           ` Pedro Franco de Carvalho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200217174931.925CFD802EA@oc3748833570.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedromfc@linux.ibm.com \
    --cc=rcardoso@linux.ibm.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox