From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43659 invoked by alias); 17 Feb 2020 17:49:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43643 invoked by uid 89); 17 Feb 2020 17:49:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=linux-nat.h, linuxnatc, UD:linux-nat.c, linuxnath X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 17:49:41 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01HHhpLJ088209 for ; Mon, 17 Feb 2020 12:49:40 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2y6dp8fqpm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 17 Feb 2020 12:49:40 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Feb 2020 17:49:38 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 17 Feb 2020 17:49:35 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01HHnVOa46531002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Feb 2020 17:49:32 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C74B242047; Mon, 17 Feb 2020 17:49:31 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B554A42042; Mon, 17 Feb 2020 17:49:31 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.214.26]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 17 Feb 2020 17:49:31 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 925CFD802EA; Mon, 17 Feb 2020 18:49:31 +0100 (CET) Subject: Re: [PATCH v2 1/3] Add low_new_clone method to linux_nat_target. To: pedromfc@linux.ibm.com (Pedro Franco de Carvalho) Date: Mon, 17 Feb 2020 17:49:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, ulrich.weigand@de.ibm.com, rcardoso@linux.ibm.com In-Reply-To: <20200214205443.1073579-2-pedromfc@linux.ibm.com> from "Pedro Franco de Carvalho" at Feb 14, 2020 05:54:41 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 20021717-0016-0000-0000-000002E7ADE3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20021717-0017-0000-0000-0000334ABE8F Message-Id: <20200217174931.925CFD802EA@oc3748833570.ibm.com> X-SW-Source: 2020-02/txt/msg00687.txt.bz2 Pedro Franco de Carvalho wrote: > This patch adds a low_new_clone method to linux_nat_target, called after > a PTRACE_EVENT_CLONE is detected, similar to how low_new_fork is called > after PTRACE_EVENT_(V)FORK. > > This is useful for targets that need to copy state associated with a > thread that is inherited across clones. Given the discussion we had last year, this is really required for a correct Power implementation of watchpoints. Given that the implementation in common code is straightforward, I this this is fine. > * linux-nat.h (low_new_clone): New method. > * linux-nat.c (linux_handle_extended_wait): Call low_new_clone. OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com