[review] Remove ARI check for multiple calls to warning or error

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/756
......................................................................


Patch Set 1:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,20 @@ 
| +Parent:     0ecf9a76 (Remove "fix" call for "long long" from ARI)
| +Author:     Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 10:40:08 -0700
| +Commit:     Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:40:08 -0700
| +
| +Remove ARI check for multiple calls to warning or error
| +
| +ARI has a check for multiple calls to warning or error, suggesting
| +that they be combined into a single call.  This triggers at three
| +places in gdb, and after examining these, I think they all make sense
| +as-is.  Instead, it makes sense to remove this check from ARI.

PS1, Line 12:

> > > What are these places?
> > 
> > See throw_bad_regnum_error, guile_repl_command, and the end of value_cast
> 
> Thanks.  (It'd be nice to have them mentioned in the commit log.)

I've made this change, and I'm going to push this series.
There's still some more work to be done before ARI is really
reliable.  What I'd like is if we could make it an ordinary
part of the build somehow, so we don't get these warnings
only after pushing.

| +
| +gdb/ChangeLog
| +2019-12-12  Tom Tromey  <tromey@adacore.com>
| +
| +	* contrib/ari/gdb_ari.sh: Remove check for multiple calls to
| +	warning or error.
| +
| +Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d
Gerrit-Change-Number: 756
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 13 Dec 2019 22:15:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment