From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52220 invoked by alias); 13 Dec 2019 22:15:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52101 invoked by uid 89); 13 Dec 2019 22:15:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 22:15:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 963CA201C2; Fri, 13 Dec 2019 17:15:18 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 5ECA8201C2; Fri, 13 Dec 2019 17:15:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3E3A220AF6; Fri, 13 Dec 2019 17:15:17 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 13 Dec 2019 22:15:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove ARI check for multiple calls to warning or error X-Gerrit-Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d X-Gerrit-Change-Number: 756 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3a8ba1d1decfd2216517a813aa986ce4f9a84461 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 13 Dec 2019 17:15:16 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191213221517.3E3A220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00625.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/756 ...................................................................... Patch Set 1: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,20 @@ | +Parent: 0ecf9a76 (Remove "fix" call for "long long" from ARI) | +Author: Tom Tromey | +AuthorDate: 2019-12-12 10:40:08 -0700 | +Commit: Tom Tromey | +CommitDate: 2019-12-12 10:40:08 -0700 | + | +Remove ARI check for multiple calls to warning or error | + | +ARI has a check for multiple calls to warning or error, suggesting | +that they be combined into a single call. This triggers at three | +places in gdb, and after examining these, I think they all make sense | +as-is. Instead, it makes sense to remove this check from ARI. PS1, Line 12: > > > What are these places? > > > > See throw_bad_regnum_error, guile_repl_command, and the end of value_cast > > Thanks. (It'd be nice to have them mentioned in the commit log.) I've made this change, and I'm going to push this series. There's still some more work to be done before ARI is really reliable. What I'd like is if we could make it an ordinary part of the build somehow, so we don't get these warnings only after pushing. | + | +gdb/ChangeLog | +2019-12-12 Tom Tromey | + | + * contrib/ari/gdb_ari.sh: Remove check for multiple calls to | + warning or error. | + | +Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d Gerrit-Change-Number: 756 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 13 Dec 2019 22:15:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Comment-In-Reply-To: Tom Tromey Gerrit-MessageType: comment