[review v10] gdb/mi: Add -symbol-info-module-{variables,functions}

["Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268
......................................................................


Patch Set 10:

> Patch Set 10: -Code-Review
> 
> Actually, when I try to build (gcc 9.2.0), I get these errors:
> 
>  /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:225:8: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror]
>    225 |        auto iter,
>        |        ^~~~
>  /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:226:8: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror]
>    226 |        auto end,
>        |        ^~~~
>  /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:261:6: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror]
>    261 |      auto iter,
>        |      ^~~~
>  /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:262:6: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror]
>    262 |      auto end,
>        |      ^~~~
> 
> You don't see this?  What do you compile with?

Gcc 7.3.1 is what's installed on my machine by default.  If I switch to a 10.0 compiler then I can reproduce this failure.

I've updated the patch and will get a better default version of GCC setup.

Sorry for wasting your time with this mistake.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe
Gerrit-Change-Number: 268
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 10:25:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment