[review v10] gdb/mi: Add -symbol-info-module-{variables,functions}

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

| --- gdb/mi/mi-symbol-cmds.c
| +++ gdb/mi/mi-symbol-cmds.c
| @@ -219,0 +256,19 @@ /* Helper for mi_info_module_functions_or_variables.  Display the results
| +   from ITER up to END or until we find a symbol that is in a different
| +   module than the first symbol we print.  Update and return the new value
| +   for ITER.  */
| +static auto
| +output_module_symbols_in_single_module (struct ui_out *uiout,
| +					auto iter,
| +					auto end,
| +					enum search_domain kind)
| +{
| +  gdb_assert ((*iter).first.symbol != nullptr);

PS8, Line 265:

Done

| +  gdb_assert ((*iter).second.symbol != nullptr);
| +
| +  /* The symbol for the module in which the first result resides.  */
| +  const symbol *first_module_symbol = (*iter).first.symbol;
| +
| +  /* Create output formatting.  */
| +  ui_out_emit_tuple module_tuple (uiout, nullptr);
| +  uiout->field_string ("module", first_module_symbol->print_name ());
| +  ui_out_emit_list files_list (uiout, "files");

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe
Gerrit-Change-Number: 268
Gerrit-PatchSet: 10
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 01:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Andrew Burgess <andrew.burgess@embecosm.com>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment