[review v3] Introduce run_on_main_thread

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/170
......................................................................


Patch Set 3:

(1 comment)

| --- /dev/null
| +++ gdb/unittests/main-thread-selftests.c
| @@ -1,0 +68,13 @@ run_tests ()
| +#endif
| +
| +}
| +}
| +
| +void
| +_initialize_main_thread_selftests ()
| +{
| +#if CXX_STD_THREAD
| +  selftests::register_test ("main_thread",

PS3, Line 77:

> Any reason this isn't named "run_on_main_thread"?

I went ahead and changed it.

> I imagine that that command could have a completer and "maint info selftests run_on<TAB>" would be the obvious thing to typo.

The command currently uses a regexp, which makes completion less
handy.  I wouldn't mind if this were changed, though.

| +			    selftests::main_thread_tests::run_tests);
| +#endif
| +}

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f
Gerrit-Change-Number: 170
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 22 Nov 2019 23:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment