From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50327 invoked by alias); 22 Nov 2019 23:05:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50315 invoked by uid 89); 22 Nov 2019 23:05:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 23:05:43 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8CF8B2046F; Fri, 22 Nov 2019 18:05:39 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 8CF3820249; Fri, 22 Nov 2019 18:05:38 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6B1F02816F; Fri, 22 Nov 2019 18:05:38 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 22 Nov 2019 23:05:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Introduce run_on_main_thread X-Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f X-Gerrit-Change-Number: 170 X-Gerrit-ChangeURL: X-Gerrit-Commit: 589c84aae29ef0c581d1a607a800f69beaaa1795 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 18:05:38 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122230538.6B1F02816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00756.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/170 ...................................................................... Patch Set 3: (1 comment) | --- /dev/null | +++ gdb/unittests/main-thread-selftests.c | @@ -1,0 +68,13 @@ run_tests () | +#endif | + | +} | +} | + | +void | +_initialize_main_thread_selftests () | +{ | +#if CXX_STD_THREAD | + selftests::register_test ("main_thread", PS3, Line 77: > Any reason this isn't named "run_on_main_thread"? I went ahead and changed it. > I imagine that that command could have a completer and "maint info selftests run_on" would be the obvious thing to typo. The command currently uses a regexp, which makes completion less handy. I wouldn't mind if this were changed, though. | + selftests::main_thread_tests::run_tests); | +#endif | +} -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I16ef82f0564e9f8a524bdc64cb31df79a988ad9f Gerrit-Change-Number: 170 Gerrit-PatchSet: 3 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 22 Nov 2019 23:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment