[review v2] [gdb/contrib] Add -c option to words.sh script

["Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/654
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> Two concerns...
> 
> 1) The current behavior, IIUC, is that comments are extracted.  Your patch changes the default behavior to extract all words. This may come as a surprise to anyone with existing scripts which use words.sh.  It might make more sense to add some other switch (perhaps -a for "all") which keeps the present default behavior intact.  It's not really that important to me that this be changed, but I thought I'd mention it.
> 

Agreed, we shouldn't change default behaviour without thinking through the consequences for others, but given that this is a very recently added script as well as that there's most likely exactly one user (me!), I think we can allow ourselves this change.

> 2) I'd like to see a line or two documenting the new switch in the blurb at the beginning of the file.

I've improved docs of '-c' in the blurb.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ifa34d435b3c41b3ff845dc07ae4b0d9f02d92a2d
Gerrit-Change-Number: 654
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Kevin Buettner <kevinb@redhat.com>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Fri, 22 Nov 2019 15:39:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment