From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14891 invoked by alias); 22 Nov 2019 15:39:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14883 invoked by uid 89); 22 Nov 2019 15:39:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 15:39:35 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0E45F202EB; Fri, 22 Nov 2019 10:39:32 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C7EE0202EB; Fri, 22 Nov 2019 10:39:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A4D512816F; Fri, 22 Nov 2019 10:39:31 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Fri, 22 Nov 2019 15:39:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Kevin Buettner Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] [gdb/contrib] Add -c option to words.sh script X-Gerrit-Change-Id: Ifa34d435b3c41b3ff845dc07ae4b0d9f02d92a2d X-Gerrit-Change-Number: 654 X-Gerrit-ChangeURL: X-Gerrit-Commit: 857d2165a5c5c6f0d4dd0ca64d54d2899def1e5c In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 10:39:31 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122153931.A4D512816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00708.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/654 ...................................................................... Patch Set 2: > Patch Set 1: Code-Review-1 > > Two concerns... > > 1) The current behavior, IIUC, is that comments are extracted. Your patch changes the default behavior to extract all words. This may come as a surprise to anyone with existing scripts which use words.sh. It might make more sense to add some other switch (perhaps -a for "all") which keeps the present default behavior intact. It's not really that important to me that this be changed, but I thought I'd mention it. > Agreed, we shouldn't change default behaviour without thinking through the consequences for others, but given that this is a very recently added script as well as that there's most likely exactly one user (me!), I think we can allow ourselves this change. > 2) I'd like to see a line or two documenting the new switch in the blurb at the beginning of the file. I've improved docs of '-c' in the blurb. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ifa34d435b3c41b3ff845dc07ae4b0d9f02d92a2d Gerrit-Change-Number: 654 Gerrit-PatchSet: 2 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Kevin Buettner Gerrit-Reviewer: Tom de Vries Gerrit-Comment-Date: Fri, 22 Nov 2019 15:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment