[review v3] [gdb/symtab] Prefer var def over decl

["Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................


Patch Set 3:

I just tested master+patch using the original example from the PR, and found that there is a difference in calling before and after start:
...
$ ./gdb.sh a.24971.out -batch -ex "p zzz"
$1 = {0x400504 "abc", 0x400508 "cde"}
$ ./gdb.sh a.24971.out -batch -ex start -ex "p zzz"
Temporary breakpoint 1 at 0x40047b: file t.c, line 6.

Temporary breakpoint 1, main () at t.c:6
6       main (void)
$1 = 0x601030 <zzz>
...

Doing the same using gdb-8.3-branch+patch, gives the required outcome in both cases. Same for  8.3 branchpoint + patch.

I'm currently doing a bisect to find out at what point this stopped working.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9
Gerrit-Change-Number: 29
Gerrit-PatchSet: 3
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 10:24:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment