[review v3] [gdb/symtab] Prefer var def over decl

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29
......................................................................


Patch Set 3: Code-Review+2

> Patch Set 3:
> 
> > Patch Set 3:
> > For me, the current patch is OK for 9.x, as it seems its impact is relatively controlled.
> > 
> > The ignore.patch fix, on the other hand, seems a little too risky for inclusion this late before we branch 9.x.
> 
> Hi Joel, thanks for the comments. Do I understand correctly then that I should commit the current patch to trunk?

I re-read the thread and the patch, and I think this is fine to check in.
One factor that helped was that I finally realized that this would only cause
more searching in the case where a declaration is found, which maybe is not
super common.
Thank you for doing this.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9
Gerrit-Change-Number: 29
Gerrit-PatchSet: 3
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 13:34:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment