[review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121
......................................................................


Patch Set 1:

(2 comments)

| --- gdb/testsuite/gdb.base/ctf-whatis.exp
| +++ gdb/testsuite/gdb.base/ctf-whatis.exp
| @@ -14,13 +14,13 @@ # You should have received a copy of the GNU General Public License
|  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
|  
|  # This file is a subset of whatis.exp written by Rob Savoye. (rob@cygnus.com)
|  
| -#
| -# test running programs
| -#
| -# -gt generates full-fledged CTF.
| +if ![compiler_supports_ctf_debug] {
| +    return 0

PS1, Line 19:

> https://sourceware.org/ml/gdb-patches/2019-10/msg00450.html reviews a very similar patch.  There I suggested using "unsupported" in these cases, since I think this is the current style.

I think that makes sense, as it leaves a trace in the .sum file.

| +}
|  
|  standard_testfile .c
| -set opts "additional_flags=-gt"
| -
| +
| +# Using `-gt` generates full-fledged CTF debug information.
| +set opts "additional_flags=-gt"
|  if { [prepare_for_testing "failed to prepare" ${testfile} \
| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -6734,8 +6734,19 @@ proc cmp_file_string { file str msg } {
|  	pass "$msg"
|      } else {
|  	fail "$msg"
|      }
|  }
|  
| +# Does the compiler support CTF debug output using '-gt' compiler
| +# flag?
| +gdb_caching_proc compiler_supports_ctf_debug {
| +    verbose -log "APB: Got here."

PS1, Line 6743:

Was it your intention to leave this logging line here?

| +    return [gdb_can_simple_compile ctfdebug {
| +	int main () {
| +	    return 0;
| +	}
| +    } executable "additional_flags=-gt"]
| +}
| +
|  # Always load compatibility stuff.
|  load_lib future.exp

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63
Gerrit-Change-Number: 121
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sat, 16 Nov 2019 22:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment