From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>
Subject: [review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function
Date: Wed, 16 Oct 2019 20:02:00 -0000 [thread overview]
Message-ID: <20191016200222.CA52120AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571177353000.I505c11169a9bc9871a31fc0c61e119f92f32cc63@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121
......................................................................
Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> Thanks for the patch.
>
> I tend to suspect this should wait for the other patch (mentioned below).
> What do you think?
That's fine. I originally posted this to the m/l while back[1], I hadn't noticed that Nick had duplicated the work since then. My main interest is the other two patches in this series.
[1] https://sourceware.org/ml/gdb-patches/2019-10/msg00220.html
next prev parent reply other threads:[~2019-10-16 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 22:09 Andrew Burgess (Code Review)
2019-10-16 18:02 ` Tom Tromey (Code Review)
2019-10-16 20:02 ` Andrew Burgess (Code Review) [this message]
2019-10-22 16:11 ` Tom Tromey (Code Review)
2019-11-16 22:45 ` Simon Marchi (Code Review)
2019-11-18 17:53 ` [review v2] " Andrew Burgess (Code Review)
2019-11-18 17:57 ` [review v3] gdb/testsuite: Introduce skip_ctf_tests " Andrew Burgess (Code Review)
2019-11-18 18:03 ` Andrew Burgess (Code Review)
2019-11-18 18:46 ` Simon Marchi (Code Review)
2019-11-18 18:47 ` Simon Marchi (Code Review)
2019-11-19 0:47 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-19 0:47 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016200222.CA52120AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox