From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review v2] Remove symbol-related static asserts
Date: Wed, 13 Nov 2019 19:33:00 -0000 [thread overview]
Message-ID: <20191113193312.7B54320AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573484025000.I51940fb2240c474838b48494b5072081701789bb@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/611
......................................................................
Patch Set 2:
(1 comment)
I agree that the asserts are best removed.
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,10 @@
| +Parent: ed2c82c3 (Consolidate setting of current_layout)
PS2, Line 1:
I agree.
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-11-11 07:43:13 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-11-12 12:52:05 -0700
| +
| +Remove symbol-related static asserts
| +
| +commit 3573abe1d added static asserts to ensure that symbol sizes
| +don't vary. However, this failed to build on Windows, on at least one
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I51940fb2240c474838b48494b5072081701789bb
Gerrit-Change-Number: 611
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 19:33:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-13 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:53 [review] Do not static assert symbol size on Windows Tom Tromey (Code Review)
2019-11-11 16:27 ` Christian Biesinger (Code Review)
2019-11-12 19:38 ` Tom Tromey (Code Review)
2019-11-12 19:39 ` Christian Biesinger (Code Review)
2019-11-12 19:56 ` [review v2] Remove symbol-related static asserts Tom Tromey (Code Review)
2019-11-12 20:02 ` Christian Biesinger (Code Review)
2019-11-13 19:33 ` Pedro Alves (Code Review) [this message]
2019-11-13 19:33 ` Pedro Alves (Code Review)
2019-11-13 20:05 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-13 20:05 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113193312.7B54320AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox