From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77320 invoked by alias); 13 Nov 2019 19:33:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77308 invoked by uid 89); 13 Nov 2019 19:33:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Nov 2019 19:33:16 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 51B4E201E8; Wed, 13 Nov 2019 14:33:14 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id A1000201E8; Wed, 13 Nov 2019 14:33:12 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7B54320AF6; Wed, 13 Nov 2019 14:33:12 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 13 Nov 2019 19:33:00 -0000 From: "Pedro Alves (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Remove symbol-related static asserts X-Gerrit-Change-Id: I51940fb2240c474838b48494b5072081701789bb X-Gerrit-Change-Number: 611 X-Gerrit-ChangeURL: X-Gerrit-Commit: db599fdcf22e154571a55285b00d096af42912d3 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 13 Nov 2019 14:33:12 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191113193312.7B54320AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00366.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/611 ...................................................................... Patch Set 2: (1 comment) I agree that the asserts are best removed. | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,10 @@ | +Parent: ed2c82c3 (Consolidate setting of current_layout) PS2, Line 1: I agree. | +Author: Tom Tromey | +AuthorDate: 2019-11-11 07:43:13 -0700 | +Commit: Tom Tromey | +CommitDate: 2019-11-12 12:52:05 -0700 | + | +Remove symbol-related static asserts | + | +commit 3573abe1d added static asserts to ensure that symbol sizes | +don't vary. However, this failed to build on Windows, on at least one -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I51940fb2240c474838b48494b5072081701789bb Gerrit-Change-Number: 611 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Wed, 13 Nov 2019 19:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment