[review] gdb: recognize new DWARF attributes: defaulted, deleted, calling conv.

["Tankut Baris Aktemur (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tankut Baris Aktemur has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135
......................................................................


Patch Set 1:

(2 comments)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h 
File gdb/gdbtypes.h:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@1101 
PS1, Line 1101: 
 986 | struct cplus_struct_type
     | ...
1096 | 
1097 |     /* * The calling convention for this type, fetched from the
1098 |        DW_AT_calling_convention attribute.  The value is one of the
1099 |        DW_CC enum dwarf_calling_convention constants.  */
1100 | 
1101 >     unsigned calling_convention : 8;
1102 |   };
1103 | 
1104 | /* * Struct used to store conversion rankings.  */
1105 | 
1106 | struct rank

> That makes sense, this is not API so we can change it however we want. […]

I assume this comment applies to the "defaulted" attribute, too.  Before I send a revision, just to clarify: I don't see another use of "enum dwarf_*" in gdbtypes.h.  In the original patch, my aim was to be consistent with the existing definition; in particular with the 'calling_convention' field in 'func_type' a little bit down (marked with another comment).  So, my question is, would this change create inconsistency in this file?


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@1144 
PS1, Line 1144: 
1137 | struct func_type
     | ...
1139 |     /* * The calling convention for targets supporting multiple ABIs.
1140 |        Right now this is only fetched from the Dwarf-2
1141 |        DW_AT_calling_convention attribute.  The value is one of the
1142 |        DW_CC enum dwarf_calling_convention constants.  */
1143 | 
1144 >     unsigned calling_convention : 8;
1145 | 
1146 |     /* * Whether this function normally returns to its caller.  It is
1147 |        set from the DW_AT_noreturn attribute if set on the
1148 |        DW_TAG_subprogram.  */
1149 | 

This is an existing definition I had aimed to be consistent with.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I54192f363115b78ec7435a8563b73fcace420765
Gerrit-Change-Number: 135
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 09:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment