From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Luis Machado <luis.machado@linaro.org>
Subject: [review v3] Don't make an extra copy + allocation of the demangled name
Date: Fri, 25 Oct 2019 18:23:00 -0000 [thread overview]
Message-ID: <20191025182315.B4E85204C9@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................
Patch Set 3:
(1 comment)
Thank you. This looks good, but I think free_demangled_name_entry needs to
be updated to destroy the new member.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/3/gdb/symtab.c
File gdb/symtab.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/3/gdb/symtab.c@914
PS3, Line 914: char *mangled_ptr = reinterpret_cast<char*> (*slot + 1);
Formatting should be `<char *>` here (missing a space).
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0
Gerrit-Change-Number: 132
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:23:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-10-25 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 22:47 [review] " Christian Biesinger (Code Review)
2019-10-21 23:19 ` Luis Machado (Code Review)
2019-10-22 4:32 ` Simon Marchi (Code Review)
2019-10-22 19:04 ` [review v2] " Christian Biesinger (Code Review)
2019-10-22 19:04 ` Christian Biesinger (Code Review)
2019-10-22 19:27 ` Simon Marchi (Code Review)
2019-10-23 16:51 ` [review v3] " Christian Biesinger (Code Review)
2019-10-25 18:23 ` Tom Tromey (Code Review) [this message]
2019-10-25 18:24 ` Tom Tromey (Code Review)
2019-10-25 19:10 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-25 19:10 ` [review v3] " Christian Biesinger (Code Review)
2019-10-25 19:10 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025182315.B4E85204C9@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox