Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	Luis Machado <luis.machado@linaro.org>
Subject: [review v2] Don't make an extra copy + allocation of the demangled name
Date: Tue, 22 Oct 2019 19:04:00 -0000	[thread overview]
Message-ID: <20191022190400.73C5923814@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................


Uploaded patch set 2.

(3 comments)

rebased

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718 
PS1, Line 718:   char* demangled;
> Usual style is "char *demangled;" i think. Although there is one offender in symtab.c already.
I rebased & followed Simon's suggestion, so this comment is moot now.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718 
PS1, Line 718:   char* demangled;
> Would it make sense to rebase that patch over your other series (especially https://gnutoolchain-ger […]
Done


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@887 
PS1, Line 887: 	 
> Something odd here? Whitespace?
Yeah, there's whitespace on this line. This was already pre-existing but I removed it now.




  parent reply	other threads:[~2019-10-22 19:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17 22:47 [review] " Christian Biesinger (Code Review)
2019-10-21 23:19 ` Luis Machado (Code Review)
2019-10-22  4:32 ` Simon Marchi (Code Review)
2019-10-22 19:04 ` [review v2] " Christian Biesinger (Code Review)
2019-10-22 19:04 ` Christian Biesinger (Code Review) [this message]
2019-10-22 19:27 ` Simon Marchi (Code Review)
2019-10-23 16:51 ` [review v3] " Christian Biesinger (Code Review)
2019-10-25 18:23 ` Tom Tromey (Code Review)
2019-10-25 18:24 ` Tom Tromey (Code Review)
2019-10-25 19:10 ` Christian Biesinger (Code Review)
2019-10-25 19:10 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-25 19:10 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022190400.73C5923814@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox