From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>, Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v4] Load system gdbinit files from a directory
Date: Wed, 23 Oct 2019 14:56:00 -0000 [thread overview]
Message-ID: <20191023145605.EED4C2192E@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1570968845000.If233859ecc21bc6421d589b37cd658a3c7d030f2@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26
......................................................................
Patch Set 4:
(4 comments)
Thanks for the review!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c
File gdb/main.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@265
PS3, Line 265: DIR *dir = nullptr;
> gdb_dir_up?
Ah thanks! Done.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@268
PS3, Line 268: if (dir != nullptr)
> Why not […]
Yes, I wanted to save an indentation level. Do you want me to change it?
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@277
PS3, Line 277: if (ent->d_name[0] == '.')
> I know that's for skipping . and .. […]
Changed to only skip . and ..
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@1039
PS3, Line 1039: ret = catch_command_errors (source_script, file.c_str (), 0);
> It's weird that ret is set but almost never checked throughout this function...
Yeah, I was wondering about too...
next prev parent reply other threads:[~2019-10-23 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1570968845000.If233859ecc21bc6421d589b37cd658a3c7d030f2@gnutoolchain-gerrit.osci.io>
2019-10-14 20:01 ` Change in binutils-gdb[master]: " Tom de Vries (Code Review)
2019-10-16 22:18 ` [review] " Christian Biesinger (Code Review)
2019-10-17 7:00 ` Eli Zaretskii
2019-10-18 11:57 ` Christian Biesinger via gdb-patches
2019-10-16 22:18 ` Christian Biesinger (Code Review)
2019-10-16 22:19 ` Christian Biesinger (Code Review)
2019-10-17 0:34 ` Tom de Vries (Code Review)
2019-10-18 11:57 ` Christian Biesinger (Code Review)
2019-10-23 14:56 ` [review v4] " Christian Biesinger (Code Review)
2019-10-23 14:56 ` Christian Biesinger (Code Review) [this message]
2019-10-24 18:59 ` Simon Marchi (Code Review)
2019-10-24 19:05 ` [review v5] " Christian Biesinger (Code Review)
2019-10-24 19:05 ` Christian Biesinger (Code Review)
2019-10-25 15:04 ` Tom Tromey (Code Review)
2019-10-29 18:35 ` Simon Marchi (Code Review)
2019-10-29 18:52 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-29 18:52 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023145605.EED4C2192E@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox