From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-160001-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 39669 invoked by alias); 23 Oct 2019 14:56:10 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 39654 invoked by uid 89); 23 Oct 2019 14:56:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2019 14:56:08 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 33320204A8; Wed, 23 Oct 2019 10:56:07 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239])	by mx1.osci.io (Postfix) with ESMTP id 0508C20471;	Wed, 23 Oct 2019 10:56:06 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id EED4C2192E;	Wed, 23 Oct 2019 10:56:05 -0400 (EDT)
X-Gerrit-PatchSet: 4
Date: Wed, 23 Oct 2019 14:56:00 -0000
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Tom de Vries <tdevries@suse.de>,	Simon Marchi <simon.marchi@polymtl.ca>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review v4] Load system gdbinit files from a directory
X-Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2
X-Gerrit-Change-Number: 26
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26>
X-Gerrit-Commit: c03726bf69004ca5e8e54519cb6a2e05562f037c
In-Reply-To: <gerrit.1570968845000.If233859ecc21bc6421d589b37cd658a3c7d030f2@gnutoolchain-gerrit.osci.io>
References: <gerrit.1570968845000.If233859ecc21bc6421d589b37cd658a3c7d030f2@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Wed, 23 Oct 2019 10:56:05 -0400
Reply-To: cbiesinger@google.com, simon.marchi@polymtl.ca, tdevries@suse.de, cbiesinger@google.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191023145605.EED4C2192E@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00833.txt.bz2

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26
......................................................................


Patch Set 4:

(4 comments)

Thanks for the review!

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c 
File gdb/main.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@265 
PS3, Line 265: 	  DIR *dir = nullptr;
> gdb_dir_up?
Ah thanks! Done.


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@268 
PS3, Line 268: 	  if (dir != nullptr)
> Why not […]
Yes, I wanted to save an indentation level. Do you want me to change it?


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@277 
PS3, Line 277: 		  if (ent->d_name[0] == '.')
> I know that's for skipping . and .. […]
Changed to only skip . and ..


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@1039 
PS3, Line 1039: 	ret = catch_command_errors (source_script, file.c_str (), 0);
> It's weird that ret is set but almost never checked throughout this function...
Yeah, I was wondering about too...